Skip to content

Bump the npm_and_yarn group across 1 directory with 2 updates #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 1 commit into
base: 1.1
Choose a base branch
from
Open

Bump the npm_and_yarn group across 1 directory with 2 updates #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"production": "cross-env NODE_ENV=production node_modules/webpack/bin/webpack.js --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js"
},
"devDependencies": {
"axios": "^0.15.3",
"axios": "^1.13.4",
"bootstrap-sass": "^3.3.7",
"cross-env": "^3.2.3",
"jquery": "^3.1.1",
Expand Down Expand Up @@ -42,7 +42,7 @@
"select2": "^4.0.3",
"simplemde": "^1.11.2",
"slugify": "^1.1.0",
"tinymce": "^4.6.3",
"tinymce": "^8.3.2",
Copy link
Copy Markdown

@sentry sentry Bot Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Custom TinyMCE plugins for YouTube and Giphy use deprecated v4 APIs like editor.addButton() which were removed in TinyMCE v5 and will break with the upgrade to v8.
Severity: HIGH

Suggested Fix

Update the custom plugins in publishable/assets/js/plugins/ to use the modern TinyMCE v8 UI registry APIs. For example, replace editor.addButton() with editor.ui.registry.addButton() and update the editor.windowManager.open() configuration to match the v8 dialog API specification.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: package.json#L45

Potential issue: The upgrade of TinyMCE from v4.6.3 to v8.3.2 will cause custom plugins
to fail. Specifically, the `publishable/assets/js/plugins/youtube/plugin.js` and
`publishable/assets/js/plugins/giphy/plugin.js` files use multiple deprecated v4 APIs,
including `editor.addButton()`, `editor.windowManager.open()`, and
`editor.addMenuItem()`. These APIs were removed in TinyMCE v5 and are not supported in
v8, which will likely cause the buttons for these plugins to not appear or function
correctly in the rich text editor.

Did we get this right? 👍 / 👎 to inform future reviews.

"toastr": "^2.1.2",
"vue": "^2.3.4"
}
Expand Down