Bump the npm_and_yarn group across 1 directory with 2 updates#1
Open
dependabot[bot] wants to merge 1 commit into
Open
Bump the npm_and_yarn group across 1 directory with 2 updates#1dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps the npm_and_yarn group with 2 updates in the / directory: [tinymce](https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce) and [axios](https://github.com/axios/axios). Updates `tinymce` from 4.9.11 to 8.3.2 - [Changelog](https://github.com/tinymce/tinymce/blob/main/modules/tinymce/CHANGELOG.md) - [Commits](https://github.com/tinymce/tinymce/commits/8.3.2/modules/tinymce) Updates `axios` from 0.15.3 to 1.13.4 - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v0.15.3...v1.13.4) --- updated-dependencies: - dependency-name: tinymce dependency-version: 8.3.2 dependency-type: direct:production dependency-group: npm_and_yarn - dependency-name: axios dependency-version: 1.13.4 dependency-type: direct:development dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
| "simplemde": "^1.11.2", | ||
| "slugify": "^1.1.0", | ||
| "tinymce": "^4.6.3", | ||
| "tinymce": "^8.3.2", |
There was a problem hiding this comment.
Bug: Custom TinyMCE plugins for YouTube and Giphy use deprecated v4 APIs like editor.addButton() which were removed in TinyMCE v5 and will break with the upgrade to v8.
Severity: HIGH
Suggested Fix
Update the custom plugins in publishable/assets/js/plugins/ to use the modern TinyMCE v8 UI registry APIs. For example, replace editor.addButton() with editor.ui.registry.addButton() and update the editor.windowManager.open() configuration to match the v8 dialog API specification.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L45
Potential issue: The upgrade of TinyMCE from v4.6.3 to v8.3.2 will cause custom plugins
to fail. Specifically, the `publishable/assets/js/plugins/youtube/plugin.js` and
`publishable/assets/js/plugins/giphy/plugin.js` files use multiple deprecated v4 APIs,
including `editor.addButton()`, `editor.windowManager.open()`, and
`editor.addMenuItem()`. These APIs were removed in TinyMCE v5 and are not supported in
v8, which will likely cause the buttons for these plugins to not appear or function
correctly in the rich text editor.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the npm_and_yarn group with 2 updates in the / directory: tinymce and axios.
Updates
tinymcefrom 4.9.11 to 8.3.2Changelog
Sourced from tinymce's changelog.
... (truncated)
Commits
4c6913bTINY-13531: Changelog (#10836)d5fdd3fTINY-12884: prevent refresh of uc-video at first level (#10797)443e2ebBump patch versioncba9379TINY-13472: Changelogs (#10799)f10e644TINY-13463: Fix views could not be toggled on init. (#10772)aa6fd62Bump version4c89695TINY-12194: Changelogs (#10763)1b4fad1TINY-13484: Fix failing CopyAndPasteTest caused by lastest Chrome (#10780)e44902fTINY-13319: Incorrect link corrected. (#10778)566b9d3TINY-13411: Adjust NPM license information to have correct links (#10776)Maintainer changes
This version was pushed to npm by tinymce, a new releaser for tinymce since your current version.
Updates
axiosfrom 0.15.3 to 1.13.4Release notes
Sourced from axios's releases.
... (truncated)
Commits
9336cf9chore(release): prepare release 1.13.4 (#7353)ee90dfcfix: issues with version 1.13.3 (#7352)af4f6d9fix: release branch yml253e3adfix: all merge configs8ff6c19refactor: ci and build (#7340)ab06109chore(release): v1.13.3 (#7335)2d6ad5erevert(deps): bump peter-evans/create-pull-request from 7 to 8 in the github-...cb49a6fchore(sponsor): update sponsor block (#7330)d8233d9fix(types): restore AxiosError.cause type from unknown to Error (#7327)5945e40fix(interceptor): handle the error in the same interceptor (#6269)Maintainer changes
This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub Actions), a new releaser for axios since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsYou can disable automated security fix PRs for this repo from the Security Alerts page.