forked from rapidpro/rapidpro
-
Notifications
You must be signed in to change notification settings - Fork 37
Delete request event view #5852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| {% extends "no_nav.html" %} | ||
| {% load smartmin compress temba %} | ||
| {% load i18n %} | ||
|
|
||
| {% block head-title %} | ||
| {% trans "Data deletion request" %} | ||
| {% endblock head-title %} | ||
| {% block page-top %} | ||
| {% endblock page-top %} | ||
| {% block content %} | ||
| <div class="flex flex-col h-full"> | ||
| <div class="inner"> | ||
| <div class="page-title mb-2">{% trans "Data deletion request received" %}</div> | ||
| <div class="centered mt-8">{% trans "Confirmation code" %}: {{ event.uuid }}</div> | ||
| </div> | ||
| </div> | ||
| {% endblock content %} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@norkans7 @ericnewcomer maybe this url.. should be something in the contacts app? E.g.
contact/forgetme/<contact-uuid>And then when the contact is deleted... it says contact deleted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we use the channel event UUID since that is the one we are creating on courier at the moment we receive the callback, retrieving the contact UUID i would be a challenge I guess and an issue if we cannot find the contact
I think if we can use the
contact/forgetme/<event-uuid>with the channel event UUID that would be fine so not the contact UUID.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we can't find the contact.. then there's no channel event and nothing to return and we noop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This URL is the one we return as confirmation URL in courier
https://github.com/nyaruka/courier/pull/834/files#diff-45e8b1f3d84682ed837b92e0ff2e697b5d885ca171ecc8c3e0d766debedb7f81R258
Do you mean we need to make courier query for the contact before adding the channel event?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Courier has to query to know if we even own the contact in question and channel events are associated with a contact.. so I think I've convinced myself that the delete status URL is just a public facing view with the contact UUID in the URL... @ericnewcomer ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked on the current approach to query the contact, and the logic we have is that we try to get a contact for a URN and if it does not exists we create a contact for it as that is the logic we want for messages
But we can adjust that to make the creation optional