Delete request event view#5852
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5852 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 490 490
Lines 25251 25264 +13
=========================================
+ Hits 25251 25264 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
08552ab to
ebbe09c
Compare
ebbe09c to
c9a3c01
Compare
c9a3c01 to
ab28187
Compare
98778aa to
a0060e5
Compare
44fd9b8 to
13b713b
Compare
a0060e5 to
893df30
Compare
13b713b to
55c8264
Compare
893df30 to
b6de6c9
Compare
55c8264 to
c7d045d
Compare
b6de6c9 to
83e8802
Compare
c7d045d to
69e84ce
Compare
69e84ce to
d396851
Compare
|
|
||
| class ChannelEventCRUDL(SmartCRUDL): | ||
| model = ChannelEvent | ||
| path = "events" # urls like /channels/events/ |
There was a problem hiding this comment.
@norkans7 @ericnewcomer maybe this url.. should be something in the contacts app? E.g.
contact/forgetme/<contact-uuid>
And then when the contact is deleted... it says contact deleted
There was a problem hiding this comment.
I think we use the channel event UUID since that is the one we are creating on courier at the moment we receive the callback, retrieving the contact UUID i would be a challenge I guess and an issue if we cannot find the contact
I think if we can use the contact/forgetme/<event-uuid> with the channel event UUID that would be fine so not the contact UUID.
There was a problem hiding this comment.
If we can't find the contact.. then there's no channel event and nothing to return and we noop
There was a problem hiding this comment.
This URL is the one we return as confirmation URL in courier
https://github.com/nyaruka/courier/pull/834/files#diff-45e8b1f3d84682ed837b92e0ff2e697b5d885ca171ecc8c3e0d766debedb7f81R258
Do you mean we need to make courier query for the contact before adding the channel event?
There was a problem hiding this comment.
Courier has to query to know if we even own the contact in question and channel events are associated with a contact.. so I think I've convinced myself that the delete status URL is just a public facing view with the contact UUID in the URL... @ericnewcomer ?
There was a problem hiding this comment.
I checked on the current approach to query the contact, and the logic we have is that we try to get a contact for a URN and if it does not exists we create a contact for it as that is the logic we want for messages
But we can adjust that to make the creation optional
|
Replaced by #5928 |
1 similar comment
|
Replaced by #5928 |

After #5867