Sparse map multiple cameras#804
Open
rsoussan wants to merge 53 commits into
Open
Conversation
Bug fixes and tuning updates
…trobee into release-0.19.1
bcoltin
approved these changes
Jul 30, 2024
Member
bcoltin
left a comment
bcoltin
left a comment
There was a problem hiding this comment.
Assuming you tested with both new and previous maps. Impressed you managed to finish this in time, great work!
Member
Author
Thanks! Yeah I tested map creation with different camera models, including merging, and localizing on maps old and new. Looks good, we might want to have @amoravargas test it with a real mapping pipeline before we merge, also haven't done granite tests |
Member
|
Make sure to fix the CI too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for using multiple cameras when making sparse maps. Updated localization node to localize with the camera params from the current robot config.
@amoravargas