Skip to content

Fix false positives for readonly classes (fix #213)#224

Open
daniil-berg wants to merge 1 commit intomoodlehq:mainfrom
daniil-berg:fix-readonly-classes
Open

Fix false positives for readonly classes (fix #213)#224
daniil-berg wants to merge 1 commit intomoodlehq:mainfrom
daniil-berg:fix-readonly-classes

Conversation

@daniil-berg
Copy link
Copy Markdown

@daniil-berg daniil-berg commented Jan 16, 2026

See #213.

Also, this discussion may be relevant.

For now, since PHPCSUtils is in the dependency tree of moodle-cs (required by phpcsstandards/phpcsextra), this should solve the issue.

EDIT: It looks like the former will become even more closely tied to PHPCS (see here), so all the more reason to use it here explicitly.

I also took the liberty of improving readability a bit by doing $token = $tokens[$i]; at the start of the loop. Hope this is OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant