Fix false positives for readonly classes (fix #213)#224
Open
daniil-berg wants to merge 1 commit intomoodlehq:mainfrom
Open
Fix false positives for readonly classes (fix #213)#224daniil-berg wants to merge 1 commit intomoodlehq:mainfrom
daniil-berg wants to merge 1 commit intomoodlehq:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #213.
Also, this discussion may be relevant.
For now, since
PHPCSUtilsis in the dependency tree ofmoodle-cs(required byphpcsstandards/phpcsextra), this should solve the issue.EDIT: It looks like the former will become even more closely tied to PHPCS (see here), so all the more reason to use it here explicitly.
I also took the liberty of improving readability a bit by doing
$token = $tokens[$i];at the start of the loop. Hope this is OK.