chore: fix most moodle plugin ci issues#46
Merged
daniil-berg merged 3 commits intomainfrom Jan 29, 2026
Merged
Conversation
- Doc blocks everywhere.
- `#[\Override]` attributes on overridden methods.
- `defined('MOODLE_INTERNAL') || die();` wherever necessary.
- Proper use of spaces/newlines.
- `final` unit test classes.
- Correct data provider function names.
- Workarounds for `local_moodlecheck` false positives.
- Explicitly disabled `Squiz.WhiteSpace.ScopeClosingBrace` for empty constructors.
- Explicitly disabled `moodle.PHP.ForbiddenTokens.Found` for unit test metric factory `eval` call.
- Reword a few things.
daniil-berg
requested review from
MartinGauk,
malteschmitz,
melanietreitinger and
serupp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#[\Override]attributes on overridden methods.defined('MOODLE_INTERNAL') || die();wherever necessary.finalunit test classes.Workarounds forSkip the Moodle PHPDoc checker entirely. (see here)local_moodlecheckfalse positives.Squiz.WhiteSpace.ScopeClosingBracefor empty constructors.moodle.PHP.ForbiddenTokens.Foundfor unit test metric factoryevalcall.What I intentionally did not fix is anything in our
local/metricsclasses (because those will be reworked separately via #11) and the false positives forfinal readonlyclasses (addressed in this PR).The latter is what is causing those nonsensical
Expected MOODLE_INTERNAL check ...errors for classes likemetric_valuefor example.