Route outline navigation to the source editor's group across windows#316828
Draft
Copilot wants to merge 2 commits into
Draft
Route outline navigation to the source editor's group across windows#316828Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
…w scenarios Co-authored-by: dmitrivMS <9581278+dmitrivMS@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix outline window function selection in child editor
Route outline navigation to the source editor's group across windows
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the Outline view (hosted in the main window) tracks an editor in an auxiliary window, clicking a symbol sometimes activates the main window instead of navigating within the auxiliary window's editor.
DocumentSymbolsOutline.revealcallsICodeEditorService.openCodeEditor(input, source, sideBySide), wheresourceis the auxiliary window's editor. The workbench implementation then opens viaeditorService.openEditor(input, ACTIVE_GROUP). Focusing/clicking the outline can shift the most-recently-active group to a main-window group, soACTIVE_GROUPno longer points at the source's group and navigation lands in the wrong window.Changes
CodeEditorService.doOpenCodeEditor: whensourceis provided andsideBySideis false, resolve the visible pane whose code editor equalssourceand target itsgroupexplicitly; fall back toACTIVE_GROUPonly if the source is no longer visible.visibleEditorPaneslookup that already drove the preview-pinning logic, so the resolved group is shared between the pin step and the open step.Behavior is unchanged when the source's group already is the active group, when
sourceis null, or when opening side-by-side.