Conversation
metal-robot
bot
added
the
area: control-plane
mac641
changed the title
… to reduce code duplication - fix previous copy-paste errors
mac641
requested review from
majst01 and
mwennrich
and removed request for
mwennrich
|
test would be nice |
There was a problem hiding this comment.
If I understand this correctly, updateImage is impossible with oci images that require any kind of auth. Is this intended?
There was a problem hiding this comment.
To be frank, I haven't dug deeper into updateImage. To my understanding this is part of the imageResource which is part of the old installation method where tarballs had to be downloaded and extracted. We don't need it for oci images since we can use github.com/google/go-containerregistry/pkg/v1/remote to download/verify/... the images from a registry.
| } | ||
|
|
||
| err = checkImageURL("image", imageURL) | ||
| err = checkImageURL("image", imageURL, nil) |
There was a problem hiding this comment.
Same here and within that file: is nil intentional?
There was a problem hiding this comment.
Since we don't have any registry yet that needs authentication, but still want to support it, I can't think of a better way than passing over nil for now.
Feel free to suggest a solution that's more to your liking and I'm happy to add it.
There was a problem hiding this comment.
Not right now. Could you create an issue for this? Then we can tackle this in the future.
3 participants
Description
References