fix(image-service): add separate url parsing check for http-based images

Author: mac641

cmd/metal-api/internal/service/image-service.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"log/slog"
 	"net/http"
+	"net/url"
 	"strconv"
 	"strings"
 	"time"
@@ -355,6 +356,11 @@ func checkImageURL(id, inputURL string, ociCredentials authn.Authenticator) erro
 
 	switch parsedURL[0] {
 	case "http", "https":
+		_, err := url.ParseRequestURI(inputURL)
+		if err != nil {
+			return fmt.Errorf("image:%s could not be parsed. error:%w", inputURL, err)
+		}
+
 		res, err := http.Head(inputURL)
 		if err != nil {
 			return fmt.Errorf("image:%s is not accessible under:%s error:%w", id, inputURL, err)

cmd/metal-api/internal/service/image-service_test.go

@@ -110,8 +110,8 @@ func TestDeleteImage(t *testing.T) {
 
 func TestCheckImageURL(t *testing.T) {
 	t.Run("Invalid URL", func(t *testing.T) {
-		err := checkImageURL("testID", "http://invalid-ürl", nil)
-		require.EqualError(t, err, "image:testID is not accessible under:http://invalid-ürl error:Head \"http://invalid-%C3%BCrl\": dial tcp: lookup xn--invalid-rl-heb: no such host")
+		err := checkImageURL("testID", "http://invalid url", nil)
+		require.EqualError(t, err, "image:http://invalid url could not be parsed. error:parse \"http://invalid url\": invalid character \" \" in host name")
 	})
 
 	t.Run("HTTP URL with successful HEAD request", func(t *testing.T) {