Conversation
|
It looks great, can you create a test for it? Check source/tests folder and copy the rapid_json_serial_test (or similar). |
|
Added a test for the gRPC serializer. |
|
@Jahsil Can you send the logs of the test passing? As it's not included in the CI yet.. |
|
16: [ RUN ] grpc_serial_test.IntPositive |
|
Running CI. |
|
But listen, the last commit is not necessary, undo it, look: |
|
It's not even building: |
|
But the real issue is this: 2026-04-07T20:56:11.5897405Z #10 7.692 -- gRPC not found, skipping grpc_serial |
|
Remove the QUIET from the import so we can debug it. |
|
@Jahsil I have done some improvements but the code is still not ready to merge, you need something like this: For finding protobuf and gRPC. How have you tested this on your PC? |
|
I will add both files |
Description
Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.
Fixes #(issue_no)
Type of change
Checklist:
make testorctest -VV -R <test-name>)../docker-compose.sh test &> outputand attached the output.OPTION_BUILD_ADDRESS_SANITIZERor./docker-compose.sh test-address-sanitizer &> outputandOPTION_TEST_MEMORYCHECK.OPTION_BUILD_THREAD_SANITIZERor./docker-compose.sh test-thread-sanitizer &> output.Helgrindin case my code works with threading.make clang-formatin order to format my code and my code follows the style guidelines.If you are unclear about any of the above checks, have a look at our documentation here.