Skip to content

Feature/add grpc serial#753

Draft
Jahsil wants to merge 11 commits intometacall:developfrom
Jahsil:feature/add-grpc-serial
Draft

Feature/add grpc serial#753
Jahsil wants to merge 11 commits intometacall:developfrom
Jahsil:feature/add-grpc-serial

Conversation

@Jahsil
Copy link
Copy Markdown

@Jahsil Jahsil commented Mar 31, 2026

Description

Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.

Fixes #(issue_no)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

Checklist:

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests/screenshots (if any) that prove my fix is effective or that my feature works.
  • I have tested the tests implicated (if any) by my own code and they pass (make test or ctest -VV -R <test-name>).
  • If my change is significant or breaking, I have passed all tests with ./docker-compose.sh test &> output and attached the output.
  • I have tested my code with OPTION_BUILD_ADDRESS_SANITIZER or ./docker-compose.sh test-address-sanitizer &> output and OPTION_TEST_MEMORYCHECK.
  • I have tested my code with OPTION_BUILD_THREAD_SANITIZER or ./docker-compose.sh test-thread-sanitizer &> output.
  • I have tested with Helgrind in case my code works with threading.
  • I have run make clang-format in order to format my code and my code follows the style guidelines.

If you are unclear about any of the above checks, have a look at our documentation here.

@viferga
Copy link
Copy Markdown
Member

viferga commented Mar 31, 2026

It looks great, can you create a test for it? Check source/tests folder and copy the rapid_json_serial_test (or similar).

@Jahsil
Copy link
Copy Markdown
Author

Jahsil commented Apr 2, 2026

Added a test for the gRPC serializer.

@viferga
Copy link
Copy Markdown
Member

viferga commented Apr 2, 2026

@Jahsil Can you send the logs of the test passing? As it's not included in the CI yet..

@Jahsil
Copy link
Copy Markdown
Author

Jahsil commented Apr 2, 2026

16: [ RUN ] grpc_serial_test.IntPositive
16: [ OK ] grpc_serial_test.IntPositive (106 ms)
16: [ RUN ] grpc_serial_test.IntNegative
16: [ OK ] grpc_serial_test.IntNegative (2 ms)
16: [ RUN ] grpc_serial_test.StringBasic
16: [ OK ] grpc_serial_test.StringBasic (2 ms)
16: [ RUN ] grpc_serial_test.StringEmpty
16: [ OK ] grpc_serial_test.StringEmpty (2 ms)
16: [ RUN ] grpc_serial_test.StringSpecialChars
16: [ OK ] grpc_serial_test.StringSpecialChars (2 ms)
16: [ RUN ] grpc_serial_test.BoolTest
16: [ OK ] grpc_serial_test.BoolTest (2 ms)
16: [ RUN ] grpc_serial_test.DoubleTest
16: [ OK ] grpc_serial_test.DoubleTest (2 ms)
16: [ RUN ] grpc_serial_test.NullTest
16: [ OK ] grpc_serial_test.NullTest (2 ms)
16: [ RUN ] grpc_serial_test.SimpleArray
16: [ OK ] grpc_serial_test.SimpleArray (2 ms)
16: [ RUN ] grpc_serial_test.SimpleMap
16: [ OK ] grpc_serial_test.SimpleMap (2 ms)
16: [ RUN ] grpc_serial_test.UnsupportedTypeFailsGracefully
16: [ OK ] grpc_serial_test.UnsupportedTypeFailsGracefully (2 ms)
100% tests passed

@viferga
Copy link
Copy Markdown
Member

viferga commented Apr 7, 2026

Running CI.

@viferga
Copy link
Copy Markdown
Member

viferga commented Apr 7, 2026

But listen, the last commit is not necessary, undo it, look:

# Check if this serial is enabled

@viferga
Copy link
Copy Markdown
Member

viferga commented Apr 7, 2026

@viferga
Copy link
Copy Markdown
Member

viferga commented Apr 7, 2026

But the real issue is this:

2026-04-07T20:56:11.5897405Z #10 7.692 -- gRPC not found, skipping grpc_serial

@viferga viferga marked this pull request as draft April 7, 2026 21:01
@viferga
Copy link
Copy Markdown
Member

viferga commented Apr 7, 2026

Remove the QUIET from the import so we can debug it.

@viferga
Copy link
Copy Markdown
Member

viferga commented Apr 12, 2026

@Jahsil I have done some improvements but the code is still not ready to merge, you need something like this:
https://github.com/IvanSafonov/grpc-cmake-example/blob/master/cmake/FindGRPC.cmake
https://github.com/IvanSafonov/grpc-cmake-example/blob/master/cmake/FindProtobuf.cmake

For finding protobuf and gRPC. How have you tested this on your PC?

@Jahsil
Copy link
Copy Markdown
Author

Jahsil commented Apr 14, 2026

I will add both files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants