ci: add cargo fmt --check to Rust CI pipeline (#747)

* ci: add cargo fmt --check to Rust CI pipeline

* ci: run rustfmt check in test job

* ci: trigger workflow run

* style: fix cargo fmt formatting in rs_port

* ci: run rust fmt check after rs_port build

* style: exclude auto-generated bindings.rs from rustfmt and fix metacall_value.rs formatting

* fix: use outer attribute in bindgen raw_line to fix build error

* ci: add rustfmt.toml to pin Rust edition for consistent formatting

Author: Harsh-dev023

.github/workflows/release-rust.yml

@@ -41,11 +41,16 @@ jobs:
         with:
           toolchain: stable
           override: true
+          components: rustfmt
 
       - name: Build the Rust Port
         working-directory: source/ports/rs_port
         run: cargo build --verbose
 
+      - name: Check Rust Formatting
+        working-directory: source/ports/rs_port
+        run: cargo fmt --check
+
       - name: Test the Rust Port
         working-directory: source/ports/rs_port
         env:

source/ports/rs_port/build.rs

@@ -2,9 +2,11 @@ use std::env;
 use std::path::PathBuf;
 
 fn generate_bindings() {
-    let manifest_dir = PathBuf::from(env::var("CARGO_MANIFEST_DIR").expect("CARGO_MANIFEST_DIR not set"));
-    let output = manifest_dir.join("src").join("bindings.rs");
+    let manifest_dir =
+        PathBuf::from(env::var("CARGO_MANIFEST_DIR").expect("CARGO_MANIFEST_DIR not set"));
+    let output = PathBuf::from(env::var("OUT_DIR").expect("OUT_DIR not set")).join("bindings.rs");
     let mut builder = bindgen::Builder::default()
+        .raw_line("#[cfg_attr(rustfmt, rustfmt::skip)]")
         .allowlist_function("metacall.*")
         .rustified_enum("metacall_.*");
 
@@ -25,12 +27,22 @@ fn generate_bindings() {
         }
 
         builder = builder
-            .clang_arg(format!("-I{}", root.join("source/metacall/include").display()))
-            .clang_arg(format!("-I{}", build_dir.join("source/metacall/include").display()))
+            .clang_arg(format!(
+                "-I{}",
+                root.join("source/metacall/include").display()
+            ))
+            .clang_arg(format!(
+                "-I{}",
+                build_dir.join("source/metacall/include").display()
+            ))
             .clang_arg(format!("-I{}", build_dir.join("source/include").display()));
     } else {
         let lib = metacall_sys::find_metacall_library().unwrap();
-        let include = lib.path.parent().expect("library path has no parent").join("include");
+        let include = lib
+            .path
+            .parent()
+            .expect("library path has no parent")
+            .join("include");
         let include_metacall = include.join("metacall");
 
         for entry in std::fs::read_dir(&include_metacall).expect("failed to read include dir") {

source/ports/rs_port/rustfmt.toml

@@ -0,0 +1 @@
+edition = "2021"

source/ports/rs_port/src/lib.rs

@@ -119,4 +119,6 @@ pub mod inline {
 
 #[allow(warnings)]
 #[doc(hidden)]
-pub mod bindings;
+pub mod bindings {
+    include!(concat!(env!("OUT_DIR"), "/bindings.rs"));
+}

source/ports/rs_port/src/types/metacall_value.rs

@@ -168,7 +168,7 @@ impl MetaCallValue for i64 {
         // TODO: This issue happens because we do not have a clear type definition in the Core
         // We are not sure yet if we should use fixed sizes in the core, or adapt all the loaders
         // and ports to the standard C int type definition. We should define this but it's not yet.
-        // Meanwhile as a workaround, we just panic if it does not fit.        
+        // Meanwhile as a workaround, we just panic if it does not fit.
         #[cfg(any(target_pointer_width = "32", windows))]
         {
             unsafe { metacall_value_create_long(self.try_into().unwrap()) }
@@ -177,7 +177,6 @@ impl MetaCallValue for i64 {
         {
             unsafe { metacall_value_create_long(self) }
         }
-
     }
 }
 /// Equivalent to MetaCall float type.