-
Notifications
You must be signed in to change notification settings - Fork 1.1k
bump pymdown-extensions to fix NoneType bug #9319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| # Copyright 2026 Marimo. All rights reserved. | ||
| """Tests for `marimo._output.doc.doc` / `mo.doc`.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import marimo as mo | ||
| from marimo._output.doc import doc | ||
| from marimo._output.hypertext import Html | ||
|
|
||
|
|
||
| def test_doc_on_mddoc_decorated_function_does_not_raise() -> None: | ||
| """Regression test for https://github.com/marimo-team/marimo/issues/9316. | ||
|
|
||
| `mo.doc` renders `_rich_help_` output (which contains a ```python fenced | ||
| code block with the object's signature) through pymdown-extensions + | ||
| pygments. pymdown-extensions <10.21.2 passed `filename=None` to pygments' | ||
| `HtmlFormatter`, and pygments >=2.20 crashed with | ||
| `AttributeError: 'NoneType' object has no attribute 'replace'`. | ||
|
|
||
| This test exercises the full pipeline end-to-end on each `@mddoc`-decorated | ||
| object used by the Layout tutorial so a regression in the pinned dependency | ||
| range is caught immediately. | ||
| """ | ||
| for obj in (mo.hstack, mo.vstack, mo.accordion, mo.callout, mo.tree): | ||
| result = doc(obj) | ||
| assert isinstance(result, Html), ( | ||
| f"doc({obj.__name__}) returned {result!r}" | ||
| ) | ||
| # The highlighted signature block should be present in the output. | ||
| assert "codehilite" in result.text | ||
| assert obj.__name__ in result.text | ||
|
|
||
|
|
||
| def test_doc_on_mddoc_decorated_method_does_not_raise() -> None: | ||
| for method in (mo.Html.center, mo.Html.right, mo.Html.left): | ||
| result = doc(method) | ||
| assert isinstance(result, Html) | ||
| assert "codehilite" in result.text | ||
|
|
||
|
|
||
| def test_doc_on_object_without_rich_help_returns_none() -> None: | ||
| """When the target object doesn't implement `_rich_help_`, `doc` should | ||
| fall back to `help(obj)` and return `None`.""" | ||
|
|
||
| class Plain: | ||
| """A plain class without `_rich_help_`.""" | ||
|
|
||
| assert doc(Plain) is None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.