bump pymdown-extensions to fix NoneType bug#9319
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bumps the minimum supported pymdown-extensions version to avoid a pygments>=2.20 crash when rendering @mddoc-decorated callables via mo.doc, and adds a regression test to ensure the pipeline doesn’t raise.
Changes:
- Bump
pymdown-extensionslower bound to>=10.21.2(core + docs extras). - Add regression tests covering
doc()on common@mddoc-decorated functions and methods.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
pyproject.toml |
Raises the pymdown-extensions minimum version to include the upstream fix for filename=None handling with pygments>=2.20. |
tests/_output/test_doc.py |
Adds end-to-end regression coverage ensuring doc() renders highlighted signatures without raising. |
akshayka
reviewed
Apr 22, 2026
Contributor
akshayka
left a comment
akshayka
left a comment
There was a problem hiding this comment.
LGTM modulo the copilot comment regarding snapshot test
mscolnick
approved these changes
Apr 22, 2026
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.23.3-dev21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Closes #9316
mo.doc(mo.hstack) (and any other @mddoc-decorated callable) crashed with AttributeError: 'NoneType' object has no attribute 'replace' when resolved against pygments>=2.20 + pymdown-extensions<10.21.2.
The root cause is upstream: pymdown-extensions <10.21.2 passes filename=None to pygments' HtmlFormatter, and pygments 2.20 stopped tolerating that. Fix released in pymdown-extensions 10.21.2, so we bump our lower bound.
📋 Pre-Review Checklist
✅ Merge Checklist