Skip to content

irem/m62.cpp: An empty dump is a NO_DUMP, not a BAD_DUMP #15337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clawgrip wants to merge 3 commits into
base: master
Choose a base branch
from
+2 −2
Open

irem/m62.cpp: An empty dump is a NO_DUMP, not a BAD_DUMP #15337

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9a3a1c
irem/m62.cpp: An empty dump is a NO_DUMP, not a BAD_DUMP
clawgrip May 13, 2026
59878a9
Restart CI
clawgrip May 14, 2026
22acac8
Add ROMREGION_ERASEFF
clawgrip May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/mame/irem/m62.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1393,7 +1393,7 @@ ROM_START( kungfub3s )
ROM_LOAD( "5.bin", 0x4000, 0x4000, CRC(8e7e4c56) SHA1(fdb79fcc652f1d0af74517e5df75921e8d3ca50f) )

ROM_REGION( 0x10000, "irem_audio:iremsound", 0 )
ROM_LOAD( "3.bin", 0xa000, 0x2000, BAD_DUMP CRC(b4293435) SHA1(5e2b96c19c4f5c63a5afa2de504d29fe64a4c908) ) // Empty ROM
ROM_LOAD( "3.bin", 0xa000, 0x2000, NO_DUMP )
Copy link
Copy Markdown
Member

@angelosa angelosa May 15, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs ROMREGION_ERASEFF to preserve current behaviour (the ROM is 1-filled).

Assuming we even want to do this, looks a YAGNI to me?

Copy link
Copy Markdown
Contributor Author

@clawgrip clawgrip May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just trying to avoid false positives when looking for new dumps matches...

Copy link
Copy Markdown
Member

@cuavas cuavas May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ROMREGION_ERASEFF fills not just the part where the dead ROM was, but also the unused part below 0xa000 with 0xff. Not sure if that’s desired. Does 0xff vs 0x00 in the dead ROM space really improve anything for the 6803?

ROM_LOAD( "2.bin", 0xc000, 0x2000, CRC(c81e31ea) SHA1(f0fc58b929188c8802cd85549bdf9f4566e6a677) ) // samples (ADPCM 4-bit)
ROM_LOAD( "1.bin", 0xe000, 0x2000, CRC(d99fb995) SHA1(caa6acdbc3b02d248fd123be95ea6fdcb4f35b59) )

Expand Down
Loading