irem/m62.cpp: An empty dump is a NO_DUMP, not a BAD_DUMP#15337
Open
clawgrip wants to merge 2 commits into
Open
irem/m62.cpp: An empty dump is a NO_DUMP, not a BAD_DUMP#15337clawgrip wants to merge 2 commits into
clawgrip wants to merge 2 commits into
Conversation
Since there's no useful information at all
angelosa
reviewed
May 15, 2026
|
|
||
| ROM_REGION( 0x10000, "irem_audio:iremsound", 0 ) | ||
| ROM_LOAD( "3.bin", 0xa000, 0x2000, BAD_DUMP CRC(b4293435) SHA1(5e2b96c19c4f5c63a5afa2de504d29fe64a4c908) ) // Empty ROM | ||
| ROM_LOAD( "3.bin", 0xa000, 0x2000, NO_DUMP ) |
Member
There was a problem hiding this comment.
Needs ROMREGION_ERASEFF to preserve current behaviour (the ROM is 1-filled).
Assuming we even want to do this, looks a YAGNI to me?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since there's no useful information at all