Skip to content

Silenced layershell warning #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stefonarch wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Silenced layershell warning #457

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e2bc5f
Silenced layershell warning
stefonarch Mar 25, 2026
9aeed20
Rebased und added min version.
stefonarch Apr 20, 2026
d381f94
Set to false
stefonarch Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ option(UPDATE_TRANSLATIONS "Update source translation translations/*.ts files" O
# Minimum Versions
set(KF6_MINIMUM_VERSION "6.0.0")
set(QT_MINIMUM_VERSION "6.6.0")
set(SHELLQT_MINIMUM_VERSION "6.0.0")
set(SHELLQT_MINIMUM_VERSION "6.6.0")
set(QTXDG_MINIMUM_VERSION "4.4.0")
set(LXQTBT_MINIMUM_VERSION "2.4.0")

Expand Down
2 changes: 1 addition & 1 deletion src/core/regionselect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ void RegionSelect::showEvent(QShowEvent *event)
layershell->setKeyboardInteractivity(LayerShellQt::Window::KeyboardInteractivityExclusive);
layershell->setExclusiveZone(-1); // not moved to accommodate for other surfaces
win->setScreen(_selectedScreen == nullptr ? qApp->primaryScreen() : _selectedScreen);
layershell->setScreenConfiguration(LayerShellQt::Window::ScreenConfiguration::ScreenFromQWindow);
layershell->setWantsToBeOnActiveScreen(true);
Copy link
Copy Markdown
Member Author

@stefonarch stefonarch Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is wrong too, but actually it makes screengrab with default=region more usable when as it will automatically select the region on the active screen and ignore the setting for the monitor.

Copy link
Copy Markdown
Member

@tsujan tsujan Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is wrong too

I'm afraid, yes. It should be

                layershell->setWantsToBeOnActiveScreen(false);
                layershell->setScreen(nullptr);

Copy link
Copy Markdown
Member Author

@stefonarch stefonarch May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this set to true when default is "region" it behaves exactly as niri's screenshot, opening the select area overlay on the current screen.
Wouldn't it be possible to make this a setting in the combo also for fullscreen? Just

  • active screen
  • screen 1
  • screen 2
  • ...

Copy link
Copy Markdown
Member

@tsujan tsujan May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal of this PR is silencing a warning, not changing usability. Doing the latter here would be very wrong.

Copy link
Copy Markdown
Member

@tsujan tsujan May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be possible to make this…

It should be, but it'll need more changes and should be done backward compatibly. Please make a feature request instead.

}
}
}
Expand Down