Silenced layershell warning#457
Conversation
|
@marcusbritanicus there are identical PRs for lxqt-runner, lxqt-session (leave), qterminal dropdown and notificationd. |
stefonarch
force-pushed
the
silence_warning
branch
from
664d1dd to
9aeed20
Compare
stefonarch
requested review from
tsujan
and removed request for
marcusbritanicus
| layershell->setExclusiveZone(-1); // not moved to accommodate for other surfaces | ||
| win->setScreen(_selectedScreen == nullptr ? qApp->primaryScreen() : _selectedScreen); | ||
| layershell->setScreenConfiguration(LayerShellQt::Window::ScreenConfiguration::ScreenFromQWindow); | ||
| layershell->setWantsToBeOnActiveScreen(true); |
There was a problem hiding this comment.
So this is wrong too, but actually it makes screengrab with default=region more usable when as it will automatically select the region on the active screen and ignore the setting for the monitor.
There was a problem hiding this comment.
So this is wrong too
I'm afraid, yes. It should be
layershell->setWantsToBeOnActiveScreen(false);
layershell->setScreen(nullptr);There was a problem hiding this comment.
With this set to true when default is "region" it behaves exactly as niri's screenshot, opening the select area overlay on the current screen.
Wouldn't it be possible to make this a setting in the combo also for fullscreen? Just
- active screen
- screen 1
- screen 2
- ...
There was a problem hiding this comment.
The goal of this PR is silencing a warning, not changing usability. Doing the latter here would be very wrong.
There was a problem hiding this comment.
Wouldn't it be possible to make this…
It should be, but it'll need more changes and should be done backward compatibly. Please make a feature request instead.
2 participants
No description provided.