Support BGRA images in Vello Classic#1173
Conversation
DJMcNab
left a comment
There was a problem hiding this comment.
This implementation looks reasonable to me.
We will need to bring this up at renderer office hours, but I think we can merge it optimistically before then.
However, I would like to see at least one test which uses this before landing.
The changelog update will need to be folded in with #1231.
DJMcNab
left a comment
There was a problem hiding this comment.
To clarify the state, this is still lightly blocked on a test. This only needs to be similar to:
vello/examples/scenes/src/test_scenes.rs
Lines 1803 to 1823 in 2bba591
That is, it can manually construct the image, rather than loading from a file.
I know, I am currently on vacation so progress is slow. I will rerequest review when ready.
This is great example, thanks. |
|
Yeah, there's no rush! I'm just noting it e.g. for office hours, so we can keep track of an accurate state |
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
This is possible because of linebender/peniko#120.