Add ImageFormat::Bgra8#120
Conversation
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
|
I'd like to see a PR properly integrating this in Vello Classic, to make sure it doesn't cause us too much pain. I think broadly we're in favour of this |
Done: linebender/vello#1173 |
|
We'll probably discuss this in renderer office hours. I can't see why it should be avoided, and the impl in Vello makes sense to me. (Obviously longer-term, the story here will need to change). This does need a changelog entry. I'm of two minds as to whether we should mark it as a breaking change. |
This is not breaking change because of |
DJMcNab
left a comment
There was a problem hiding this comment.
We discussed this in #office hours > 2025-08-28, and have decided that we are able to support this.
This still needs a CHANGELOG entry, but then I'll be happy to approve this.
Thanks!
Similar as in #120, although I think this one is even more important as vello_cpu currently accepts only premultiplied images while vello classic only unpremultiplied. This will hopefully allow vello_cpu to use peniko's image type natively. --------- Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> Co-authored-by: Daniel McNab <36049421+DJMcNab@users.noreply.github.com>
This is possible because of linebender/peniko#120. --------- Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Vello can handle this easily withtextureSamplewhich automagically makes it RGBA.Actually vello uses
textureLoadand atlas texture, so we would need to implement this as in vello_cpu, preferably with swaping on image cmd (this should be just bgra vs rgba swizle).