Skip to content

fix: let try? continue after maxRecDepth #13838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
raphael-solace wants to merge 1 commit into from
+11 −0
Closed

fix: let try? continue after maxRecDepth #13838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Lean/Elab/Tactic/Try.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,8 @@ def withOriginalHeartbeats (x : TryTacticM α) : TryTacticM α := do
(fun ex => do
if Exception.isMaxHeartbeat ex then
throwError "tactic exceeded heartbeat limit"
else if ex.isMaxRecDepth then
throwError "tactic exceeded recursion depth limit"
else
throw ex)

Expand Down
9 changes: 9 additions & 0 deletions tests/elab/try_eval_suggest.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,12 @@ example (h : 1 = 1) : 1 = 1 := by
#guard_msgs (info) in
example : 1 = 1 := by
try? (max := 1) => attempt_all | rfl | simp_all

-- A resource-limit error in one branch should not prevent other branches from producing suggestions.
/--
info: Try this:
[apply] grind
-/
#guard_msgs (substring := true) in
example (f : Nat → Nat) (x : Nat) (h : x = f x) : x = f (f x) := by
try?
Copy link
Copy Markdown
Collaborator

@nomeata nomeata May 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this test more reliable by using try? => and a tactic that definitely triggers or explicitly throws maxrecdepth

Loading