fix: let try? continue after maxRecDepth#13838
Closed
raphael-solace wants to merge 1 commit into
Closed
Conversation
Author
|
changelog-tactics |
nomeata
reviewed
May 25, 2026
| -/ | ||
| #guard_msgs (substring := true) in | ||
| example (f : Nat → Nat) (x : Nat) (h : x = f x) : x = f (f x) := by | ||
| try? |
Collaborator
There was a problem hiding this comment.
Can you make this test more reliable by using try? => and a tactic that definitely triggers or explicitly throws maxrecdepth
github-actions
Bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lets
try?continue evaluating other candidate branches when one branch hits Lean's recursion-depth resource limit.try?already converts heartbeat exhaustion into an ordinary branch failure. This applies the same treatment tomaxRecDepth, so an expensivesimp/simp_allcandidate does not suppress a usefulgrindsuggestion.Closes #13216.