CHECK-394: Move Project video, stats, dates and PLOT properties into their own GraphQL fragments#2908
Open
amy-at-kickstarter wants to merge 7 commits into
Open
Conversation
amy-at-kickstarter
force-pushed
the
feat/adyer/check-394/move-other-project-props
branch
from
accfee6 to
826f0c7
Compare
Collaborator
Generated by 🚫 Danger |
amy-at-kickstarter
changed the base branch from
main
to
feat/adyer/check/extended-project-properties
amy-at-kickstarter
changed the title
| } | ||
| watchesCount | ||
| ...NoRewardRewardFragment | ||
| ...ExtendedProjectPropertiesFragment |
Contributor
Author
There was a problem hiding this comment.
Moved a few things to make them alphabetical.
| ), | ||
| let categoryFragment = projectFragment.category?.fragments.categoryFragment, | ||
| let dates = projectDates(from: projectFragment), | ||
| let dates = projectDates(from: projectFragment.fragments.projectDatesFragment), |
Contributor
Author
There was a problem hiding this comment.
This is basically what all of the changes do: instead of passing around the entire ProjectFragment to these different parsing methods, it passes a sub-fragment.
I made no changes to the parsing methods themselves, which should catch me if I accidentally moved or deleted a field.
amy-at-kickstarter
requested review from
a team and
scottkicks
and removed request for
a team
Base automatically changed from
feat/adyer/check/extended-project-properties
to
main
July 9, 2026 13:29
amy-at-kickstarter
force-pushed
the
feat/adyer/check-394/move-other-project-props
branch
from
826f0c7 to
2000ab8
Compare
amy-at-kickstarter
requested review from
stevestreza-ksr
and removed request for
scottkicks
Contributor
Author
|
@stevestreza-ksr Sending this one to you too since it makes more sense in context of the other review you just did |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📲 What
Move several chunks of
Projectinto their own sub-fragments inProjectFragment:🤔 Why
I'm working on code that will speed up loading on the Project page. As part of that, I'm going to make a faster version of ProjectFragment, which fetches only the fields required for Checkout.
This is a piece of that cleanup. By moving these fields into their own fragments, it will be easier to control which fields we fetch on ProjectFragment (or to create a new, similar fragment).
🛠 How
These changes just move around how the data is fetched - there should be no net effects from doing this.
All of these fields are well-tested in
Project+ProjectFragmentTests.swift.