CHECK-403: Use fxRateCurrency on Project for user selected currency code#2911
Open
amy-at-kickstarter wants to merge 3 commits into
Open
CHECK-403: Use fxRateCurrency on Project for user selected currency code#2911amy-at-kickstarter wants to merge 3 commits into
amy-at-kickstarter wants to merge 3 commits into
Conversation
amy-at-kickstarter
force-pushed
the
feat/adyer/check-403/use-fxratecurrency
branch
from
c24c8ac to
5bb58a6
Compare
amy-at-kickstarter
changed the base branch from
feat/adyer/check-394/move-other-project-props
to
feat/adyer/check-403/base
amy-at-kickstarter
changed the title
| } | ||
| } | ||
|
|
||
| internal func fetchProject(projectParam: Param, configCurrency _: String?) |
Contributor
Author
There was a problem hiding this comment.
This feels much cleaner.
amy-at-kickstarter
requested review from
a team and
stevestreza-ksr
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📲 What
Use
fxRateCurrencyon Project for the user's selected currency code when creating aProject.🤔 Why
The user's chosen currency lives on the
Userobject in GraphQL, not on theProject. That meant we had a lot of extra plumbing to pass it down - either fromAppEnvironment.current.currentUser, or from a top-level GraphQL query likeme { currency }.To clean this up, I added the GraphQL field
fxRateCurrencytoProjectFragment. This field matches the user's chosen currency (the same one used for thefxRate).This PR also depends on #2910 and #2908. I created a separate base branch with both those changes for clarity.