Skip to content

Remove the legacy podio I/O components and services#392

Merged
jmcarcell merged 16 commits into
key4hep:mainfrom
tmadlener:rm-podio-datasvc
May 20, 2026
Merged

Remove the legacy podio I/O components and services#392
jmcarcell merged 16 commits into
key4hep:mainfrom
tmadlener:rm-podio-datasvc

Conversation

@tmadlener

@tmadlener tmadlener commented Apr 2, 2026

Copy link
Copy Markdown
Member

BEGINRELEASENOTES

  • Remove the legacy podio I/O components and services (PodioDataSvc, k4DataSvc, FCCDataSvc, PodioInput, PodioOutput and MetaDataHandle). These have been marked as deprecated before.
  • Switch all existing tests over to use IOSvc and EventDataSvc based I/O and TES instead
  • Remove a few test cases which explicitly covered k4DataSvc functionality only and for which we have an equivalent test already for IOSvc

ENDRELEASENOTES

@tmadlener tmadlener force-pushed the rm-podio-datasvc branch 2 times, most recently from d43145b to 0fe7f39 Compare April 2, 2026 20:05
@tmadlener

Copy link
Copy Markdown
Member Author

I can build a local stack with these changes and all the linked PRs.

@jmcarcell

Copy link
Copy Markdown
Member

I have pushed a few commits removing references and old files.

@jmcarcell

Copy link
Copy Markdown
Member

Some tests could not be needed anymore because what they do now is also done in other tests. TwoProducers.py simple has two algorithms producing, but we have other tests doing that too.

@tmadlener

Copy link
Copy Markdown
Member Author

For the tests I have removed a few but I have not done a really comprehensive survey of which ones are also covered somewhere else. Should we do this in this PR or do we do another one? I am happy to do either.

@jmcarcell

Copy link
Copy Markdown
Member

I think it can be done here since there can't be that many; the candidates are the ones that are modified to use IOSvc. I had a look yesterday and only TwoProducers.py was clearly redundant. Maybe also https://github.com/key4hep/k4FWCore/blob/main/test/k4FWCoreTest/CMakeLists.txt#L133 but the other versions of CheckExampleEventData do other things.

@tmadlener

Copy link
Copy Markdown
Member Author

I will have another look and update this PR accordingly.

@tmadlener tmadlener force-pushed the rm-podio-datasvc branch 2 times, most recently from 1f40188 to 58fed12 Compare April 16, 2026 07:32
@jmcarcell jmcarcell force-pushed the rm-podio-datasvc branch from 9486c03 to cf33107 Compare May 7, 2026 20:22
giovannimarchiori pushed a commit to HEP-FCC/k4RecCalorimeter that referenced this pull request May 13, 2026
Following key4hep/k4FWCore#392

Co-authored-by: Juan Miguel Carceller <jmcarcell@users.noreply.github.com>
@jmcarcell jmcarcell marked this pull request as ready for review May 14, 2026 12:18
@jmcarcell jmcarcell changed the title [WIP] Remove the legacy podio I/O components and services Remove the legacy podio I/O components and services May 14, 2026
@jmcarcell jmcarcell linked an issue May 15, 2026 that may be closed by this pull request
3 tasks
@jmcarcell jmcarcell merged commit d48f0fa into key4hep:main May 20, 2026
3 of 8 checks passed
@jmcarcell

jmcarcell commented May 20, 2026

Copy link
Copy Markdown
Member

Merging so that we have a few builds before CHEP, so I can fix issues if any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate: PodioInput, k4DataSvc, PodioDataSvc, (FCCDataSvc)

2 participants