Use IOSvc: remove PodioDataSvc and PodioOutput#23
Merged
Conversation
varnes
suggested changes
May 20, 2026
varnes
left a comment
varnes
left a comment
Contributor
There was a problem hiding this comment.
Hi @jmcarcell This change looks fine to me, but there should be a corresponding update to the README.md (to remove the reference to evtsvc there)
15 tasks
Member
Author
|
Where in the README? |
Contributor
|
Hi @jmcarcell , It's this part of the README: evtsvc.input = "root/allegro_v03_evts_10000_*sim.root" Since the corresponding line in the python has been changed to iosvc.Input = "root/allegro_v03_evts_10000_test_sim.root" |
varnes
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
following what was done in key4hep/k4FWCore#392.
I removed the output file since
drop *is being used so that is like not having output, I'm not sure if that's intended.