[7.0] Remove static methods from frontend modules

modules/mod_articles_archive/src/Helper/ArticlesArchiveHelper.php

@@ -99,27 +99,4 @@ public function getArticlesByMonths(Registry $moduleParams, SiteApplication $app
 
         return $lists;
     }
-
-    /**
-     * Retrieve list of archived articles
-     *
-     * @param   Registry  &$params module parameters
-     *
-     * @return  \stdClass[]
-     *
-     * @since   1.5
-     *
-     * @deprecated  4.4.0  will be removed in 7.0
-     *              Use the non-static method getArticlesByMonths
-     *              Example: Factory::getApplication()->bootModule('mod_articles_archive', 'site')
-     *                           ->getHelper('ArticlesArchiveHelper')
-     *                           ->getArticlesByMonths($params, Factory::getApplication())
-     */
-    public static function getList(&$params)
-    {
-        /** @var SiteApplication $app */
-        $app = Factory::getApplication();
-
-        return (new self())->getArticlesByMonths($params, $app);
-    }
 }

modules/mod_articles_categories/src/Helper/ArticlesCategoriesHelper.php

@@ -13,7 +13,6 @@
 use Joomla\CMS\Application\SiteApplication;
 use Joomla\CMS\Categories\CategoryInterface;
 use Joomla\CMS\Categories\CategoryNode;
-use Joomla\CMS\Factory;
 use Joomla\Database\DatabaseAwareInterface;
 use Joomla\Database\DatabaseAwareTrait;
 use Joomla\Registry\Registry;
@@ -70,27 +69,4 @@ public function getChildrenCategories(Registry $moduleParams, SiteApplication $a
 
         return $childrenCategories;
     }
-
-    /**
-     * Get list of categories
-     *
-     * @param   Registry  $params  module parameters
-     *
-     * @return  array
-     *
-     * @since   1.6
-     *
-     * @deprecated  4.4.0  will be removed in 7.0
-     *              Use the non-static method getChildrenCategories
-     *              Example: Factory::getApplication()->bootModule('mod_articles_categories', 'site')
-     *                           ->getHelper('ArticlesCategoriesHelper')
-     *                           ->getChildrenCategories($params, Factory::getApplication())
-     */
-    public static function getList($params)
-    {
-        /** @var SiteApplication $app */
-        $app = Factory::getApplication();
-
-        return (new self())->getChildrenCategories($params, $app);
-    }
 }

modules/mod_articles_category/src/Helper/ArticlesCategoryHelper.php

@@ -14,7 +14,6 @@
 use Joomla\CMS\Application\SiteApplication;
 use Joomla\CMS\Component\ComponentHelper;
 use Joomla\CMS\Date\Date;
-use Joomla\CMS\Factory;
 use Joomla\CMS\HTML\HTMLHelper;
 use Joomla\CMS\Plugin\PluginHelper;
 use Joomla\CMS\Router\Route;
@@ -316,29 +315,6 @@ public function getArticles(Registry $params, SiteApplication $app)
         return $items;
     }
 
-    /**
-     * Get a list of articles from a specific category
-     *
-     * @param   Registry  &$params  object holding the models parameters
-     *
-     * @return  array  The array of users
-     *
-     * @since   1.6
-     *
-     * @deprecated  4.4.0  will be removed in 7.0
-     *              Use the non-static method getArticles
-     *              Example: Factory::getApplication()->bootModule('mod_articles_category', 'site')
-     *                           ->getHelper('ArticlesCategoryHelper')
-     *                           ->getArticles($params, Factory::getApplication())
-     */
-    public static function getList(&$params)
-    {
-        /* @var SiteApplication $app */
-        $app = Factory::getApplication();
-
-        return (new self())->getArticles($params, $app);
-    }
-
     /**
      * Strips unnecessary tags from the introtext
      *

modules/mod_articles_latest/src/Helper/ArticlesLatestHelper.php

@@ -13,7 +13,6 @@
 use Joomla\CMS\Access\Access;
 use Joomla\CMS\Application\SiteApplication;
 use Joomla\CMS\Component\ComponentHelper;
-use Joomla\CMS\Factory;
 use Joomla\CMS\Router\Route;
 use Joomla\Component\Content\Site\Helper\RouteHelper;
 use Joomla\Component\Content\Site\Model\ArticlesModel;
@@ -145,25 +144,4 @@ public function getArticles(Registry $params, SiteApplication $app)
 
         return $items;
     }
-
-    /**
-     * Retrieve a list of articles
-     *
-     * @param   Registry       $params  The module parameters.
-     * @param   ArticlesModel  $model   The model.
-     *
-     * @return  mixed
-     *
-     * @since   1.6
-     *
-     * @deprecated 4.3 will be removed in 7.0
-     *             Use the non-static method getArticles
-     *             Example: Factory::getApplication()->bootModule('mod_articles_latest', 'site')
-     *                          ->getHelper('ArticlesLatestHelper')
-     *                          ->getArticles($params, Factory::getApplication())
-     */
-    public static function getList(Registry $params, ArticlesModel $model)
-    {
-        return (new self())->getArticles($params, Factory::getApplication());
-    }
 }

modules/mod_articles_news/src/Helper/ArticlesNewsHelper.php

@@ -13,7 +13,6 @@
 use Joomla\CMS\Access\Access;
 use Joomla\CMS\Application\SiteApplication;
 use Joomla\CMS\Component\ComponentHelper;
-use Joomla\CMS\Factory;
 use Joomla\CMS\HTML\HTMLHelper;
 use Joomla\CMS\Language\Text;
 use Joomla\CMS\Router\Route;
@@ -187,24 +186,4 @@ public function getArticles(Registry $params, SiteApplication $app)
 
         return $items;
     }
-
-    /**
-     * Get a list of the latest articles from the article model
-     *
-     * @param   \Joomla\Registry\Registry  &$params  object holding the models parameters
-     *
-     * @return  mixed
-     *
-     * @since 1.6
-     *
-     * @deprecated 4.3 will be removed in 7.0
-     *             Use the non-static method getArticles
-     *             Example: Factory::getApplication()->bootModule('mod_articles_news', 'site')
-     *                          ->getHelper('ArticlesNewsHelper')
-     *                          ->getArticles($params, Factory::getApplication())
-     */
-    public static function getList(&$params)
-    {
-        return (new self())->getArticles($params, Factory::getApplication());
-    }
 }

modules/mod_articles_popular/src/Helper/ArticlesPopularHelper.php

@@ -161,24 +161,4 @@ private function prepareItem($item, $params): object
 
         return $item;
     }
-
-    /**
-     * Get a list of popular articles from the articles model
-     *
-     * @param   \Joomla\Registry\Registry  &$params  object holding the models parameters
-     *
-     * @return  mixed
-     *
-     * @since  4.3.0
-     *
-     * @deprecated 4.3 will be removed in 7.0
-     *             Use the non-static method getArticles
-     *             Example: Factory::getApplication()->bootModule('mod_articles_popular', 'site')
-     *                          ->getHelper('ArticlesPopularHelper')
-     *                          ->getArticles($params, Factory::getApplication())
-     */
-    public static function getList(&$params)
-    {
-        return (new self())->getArticles($params, Factory::getApplication());
-    }
 }

modules/mod_breadcrumbs/src/Helper/BreadcrumbsHelper.php

@@ -10,9 +10,7 @@
 
 namespace Joomla\Module\Breadcrumbs\Site\Helper;
 
-use Joomla\CMS\Application\CMSApplication;
 use Joomla\CMS\Application\SiteApplication;
-use Joomla\CMS\Factory;
 use Joomla\CMS\Language\Multilanguage;
 use Joomla\Registry\Registry;
 
@@ -86,46 +84,4 @@ public function getHomeItem(Registry $params, SiteApplication $app): object
 
         return $item;
     }
-
-    /**
-     * Retrieve breadcrumb items
-     *
-     * @param   Registry        $params  The module parameters
-     * @param   CMSApplication  $app     The application
-     *
-     * @return  array
-     *
-     * @since   1.5
-     *
-     * @deprecated 4.4.0 will be removed in 7.0
-     *             Use the non-static method getBreadcrumbs
-     *             Example: Factory::getApplication()->bootModule('mod_breadcrumbs', 'site')
-     *                          ->getHelper('BreadcrumbsHelper')
-     *                          ->getBreadcrumbs($params, Factory::getApplication())
-     */
-    public static function getList(Registry $params, CMSApplication $app)
-    {
-        return (new self())->getBreadcrumbs($params, Factory::getApplication());
-    }
-
-    /**
-     * Retrieve home item (start page)
-     *
-     * @param   Registry        $params  The module parameters
-     * @param   CMSApplication  $app     The application
-     *
-     * @return  object
-     *
-     * @since   4.2.0
-     *
-     * @deprecated 4.4.0 will be removed in 7.0
-     *             Use the non-static method getHomeItem
-     *             Example: Factory::getApplication()->bootModule('mod_breadcrumbs', 'site')
-     *                          ->getHelper('BreadcrumbsHelper')
-     *                          ->getHomeItem($params, Factory::getApplication())
-     */
-    public static function getHome(Registry $params, CMSApplication $app)
-    {
-        return (new self())->getHomeItem($params, Factory::getApplication());
-    }
 }

modules/mod_related_items/src/Helper/RelatedItemsHelper.php

@@ -176,27 +176,4 @@ public function getRelatedArticles(Registry $params, SiteApplication $app): arra
 
         return $related;
     }
-
-    /**
-     * Get a list of related articles
-     *
-     * @param   Registry  &$params  module parameters
-     *
-     * @return  array
-     *
-     * @since   1.6
-     *
-     * @deprecated  4.4.0  will be removed in 7.0
-     *              Use the non-static method getRelatedArticles
-     *              Example: Factory::getApplication()->bootModule('mod_related_items', 'site')
-     *                           ->getHelper('RelatedItemsHelper')
-     *                           ->getRelatedArticles($params, Factory::getApplication())
-     */
-    public static function getList(&$params)
-    {
-        /** @var SiteApplication $app */
-        $app = Factory::getApplication();
-
-        return (new self())->getRelatedArticles($params, $app);
-    }
 }

modules/mod_users_latest/src/Helper/UsersLatestHelper.php

@@ -11,7 +11,6 @@
 namespace Joomla\Module\UsersLatest\Site\Helper;
 
 use Joomla\CMS\Application\SiteApplication;
-use Joomla\CMS\Factory;
 use Joomla\CMS\Language\Text;
 use Joomla\Database\DatabaseAwareInterface;
 use Joomla\Database\DatabaseAwareTrait;
@@ -75,24 +74,4 @@ public function getLatestUsers(Registry $params, SiteApplication $app): array
             return [];
         }
     }
-
-    /**
-     * Get users sorted by activation date
-     *
-     * @param   \Joomla\Registry\Registry  $params  module parameters
-     *
-     * @return  array  The array of users
-     *
-     * @since   1.6
-     *
-     * @deprecated 4.4.0 will be removed in 7.0
-     *             Use the non-static method getLatestUsers
-     *             Example: Factory::getApplication()->bootModule('mod_users_latest', 'site')
-     *                          ->getHelper('UsersLatestHelper')
-     *                          ->getLatestUsers($params, Factory::getApplication())
-     */
-    public static function getUsers($params)
-    {
-        return (new self())->getLatestUsers($params, Factory::getApplication());
-    }
 }