[7.0] Remove static methods from frontend modules#45860
Conversation
|
I have tested this item ✅ successfully on 2b27aee This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45860. |
|
I have tested this item ✅ successfully on 2b27aee This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45860. |
|
@Hackwar Any reasons why this PR is in draft mode? It has received 2 successful human tests meanwhile. |
|
I have tested this item 🔴 unsuccessfully on 2b27aee This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45860. |
|
@vishalchincholi1 if you try to test this PR via Joomla Patch Tester even with the latest Nightly Build, you will get the error: The file marked for modification does not exist: phpstan-baseline.neon Use the Download package instead :) |
|
I have removed the unsuccessful test from @vishalchincholi1 as they had not tested the pr This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45860. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45860. |
|
@RickR2H please remove the RTC label. This PR is still in draft mode and it has conflicts that need to be resolved |
|
Back to draft This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45860. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Summary of Changes
This PR removes static methods from the helpers of the frontend modules. The rest is removed in #47460.
Testing Instructions
Codereview
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: [7.0] Removal of static helper methods from modules Manual#608
No documentation changes for manual.joomla.org needed