Skip to content

[7.0] Remove static methods from frontend modules#45860

Open
Hackwar wants to merge 5 commits into
joomla:7.0-devfrom
Hackwar:6.0-deprecations-modules
Open

[7.0] Remove static methods from frontend modules#45860
Hackwar wants to merge 5 commits into
joomla:7.0-devfrom
Hackwar:6.0-deprecations-modules

Conversation

@Hackwar
Copy link
Copy Markdown
Member

@Hackwar Hackwar commented Aug 6, 2025

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

This PR removes static methods from the helpers of the frontend modules. The rest is removed in #47460.

Testing Instructions

Codereview

Link to documentations

Please select:

@bembelimen bembelimen added the bug label Aug 20, 2025
@hans2103
Copy link
Copy Markdown
Contributor

hans2103 commented Sep 3, 2025

I have tested this item ✅ successfully on 2b27aee


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45860.

@ceford
Copy link
Copy Markdown
Contributor

ceford commented Sep 17, 2025

I have tested this item ✅ successfully on 2b27aee

Code review: I see no calls to ::getList() in J6 and I see that some of these items will be removed in 6 and others in 7. Looks OK in my limited experience!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45860.

@richard67
Copy link
Copy Markdown
Member

@Hackwar Any reasons why this PR is in draft mode? It has received 2 successful human tests meanwhile.

@vishalchincholi1
Copy link
Copy Markdown

I have tested this item 🔴 unsuccessfully on 2b27aee

Getting this error on locally while applying the patch
The file marked for modification does not exist: phpstan-baseline.neon


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45860.

@brianteeman
Copy link
Copy Markdown
Contributor

@vishalchincholi1 if you try to test this PR via Joomla Patch Tester even with the latest Nightly Build, you will get the error: The file marked for modification does not exist: phpstan-baseline.neon Use the Download package instead :)

@brianteeman
Copy link
Copy Markdown
Contributor

I have removed the unsuccessful test from @vishalchincholi1 as they had not tested the pr


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45860.

@RickR2H
Copy link
Copy Markdown
Member

RickR2H commented Jan 31, 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45860.

@RickR2H RickR2H removed the bug label Jan 31, 2026
@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 31, 2026
@brianteeman
Copy link
Copy Markdown
Contributor

@RickR2H please remove the RTC label. This PR is still in draft mode and it has conflicts that need to be resolved

@RickR2H
Copy link
Copy Markdown
Member

RickR2H commented Jan 31, 2026

Back to draft


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45860.

@RickR2H RickR2H removed the RTC This Pull Request is Ready To Commit label Jan 31, 2026
@Hackwar Hackwar changed the base branch from 6.0-dev to 7.0-dev February 28, 2026 14:18
@Hackwar Hackwar changed the title [6.0] Remove static methods from frontend modules [7.0] Remove static methods from frontend modules Feb 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.