Fixing issue 693: Avoid simple caches#702
Conversation
- Updated XPath to allow Calendar.getInstance() usage in main methods. - Refined detection logic to focus on inefficient heavyweight object creation. - Resolved conflict with UnresolvedType property descriptors. - Closes jborgers#693
…mance documentation
|
@MohammedGhallab thanks for your PR! We will review it. |
stokpop
left a comment
stokpop
left a comment
There was a problem hiding this comment.
Sorry for the delay. Looks good to me. One request.
|
jborgers
left a comment
jborgers
left a comment
There was a problem hiding this comment.
Looking good, thanks for the contribution!
|
Hi @MohammedGhallab, as a follow-up on your contribution we made an effort to improve the docs on how to contribute to the jPinpoint rules. Can you please have a look at: CONTRIBUTING.md. Does that help? Feedback is much appreciated. Thanks! |
Thank you for the update! I’ve reviewed the new CONTRIBUTING.md and it is much more structured now.Specifically, the clear distinction between Java and Kotlin paths, and the detailed conventions for XML unit test files (like the block requirements), make it much easier for new contributors to ensure their PRs align with the project’s standards from the start.The addition of the Maven profile details for Kotlin (kotlin-pmd7) and the steps for the ruleset merger tool are also very helpful additions. This definitely streamlines the setup process.I’ll make sure to follow these guidelines in my upcoming contributions. Thanks for the effort in improving the developer experience! |
3 participants
Revert "fix(rules): reduce false positives in AvoidCalendarDateCreation"
and fixing issue 693