Merge pull request #702 from MohammedGhallab/pmd7

Fixing issue 693: Avoid simple caches

Author: stokpop

docs/JavaCodePerformance.md

@@ -1411,7 +1411,28 @@ public class CacheKeyGenerator // bad, unclear name
   }
 }
 ```
+#### IC18
 
+**Observation: Simple caching providers like `SimpleCacheManager` or `ConcurrentMapCache` are used in production.** **Problem:** These simple implementations are intended for testing and prototyping. They lack critical production features such as eviction policies (e.g., LRU), maximum size limits, and manageability. This can lead to memory leaks and `OutOfMemoryError` as the cache grows indefinitely.  
+**Solution:** Use a robust, production-ready caching provider like **Caffeine**, **Ehcache**, or a distributed solution like **Redis**.  
+**Example:**
+```java
+// Bad: Simple caching with no limits
+@Bean 
+public CacheManager cacheManager() {
+    return new SimpleCacheManager().setCaches(Arrays.asList(new ConcurrentMapCache("myCache")));
+}
+
+// Good: Using Caffeine with size and time limits
+@Bean
+public CacheManager cacheManager() {
+    CaffeineCacheManager cacheManager = new CaffeineCacheManager("myCache");
+    cacheManager.setCaffeine(Caffeine.newBuilder()
+        .maximumSize(1000)
+        .expireAfterWrite(10, TimeUnit.MINUTES));
+    return cacheManager;
+}
+```
 Too much session usage
 ----------------------
 

rulesets/java/jpinpoint-java-rules.xml

@@ -6890,7 +6890,7 @@ public ModelAndView initialOverviewRender(RenderRequest request, String viewName
     </rule>
 
     <rule name="AvoidSimpleCaches" class="net.sourceforge.pmd.lang.rule.xpath.XPathRule" language="java" message="Avoid simple caching in production"
-          externalInfoUrl="https://github.com/jborgers/PMD-jPinpoint-rules/tree/pmd7/docs/JavaCodePerformance.md#ic08">
+          externalInfoUrl="https://github.com/jborgers/PMD-jPinpoint-rules/tree/pmd7/docs/JavaCodePerformance.md#ic18">
         <description>Simple caches are used. Problem: Simple caching is meant for testing and prototyping plus it lacks manageability and monitorability.&#13;
             Solution: Use a proper cache implementation like ehcache or a cloud cache.
             (jpinpoint-rules)</description>

src/main/resources/category/java/spring.xml

@@ -426,7 +426,7 @@ class Good {
     </rule>
 
     <rule name="AvoidSimpleCaches" class="net.sourceforge.pmd.lang.rule.xpath.XPathRule" language="java" message="Avoid simple caching in production"
-          externalInfoUrl="${doc_root}/JavaCodePerformance.md#ic08">
+          externalInfoUrl="${doc_root}/JavaCodePerformance.md#ic18">
         <description>Simple caches are used. Problem: Simple caching is meant for testing and prototyping plus it lacks manageability and monitorability.&#13;
             Solution: Use a proper cache implementation like ehcache or a cloud cache.
             (jpinpoint-rules)</description>