Bump deps #407
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -10,10 +10,10 @@ jobs: | |||||
| lint: | ||||||
| runs-on: ubuntu-latest | ||||||
| steps: | ||||||
| - uses: actions/checkout@v6 | ||||||
| - uses: actions/setup-go@v6 | ||||||
| with: | ||||||
| go-version: '1.26.x' | ||||||
|
There was a problem hiding this comment.
Useful? React with 👍 / 👎. |
||||||
| - name: golangci-lint | ||||||
| uses: golangci/golangci-lint-action@v7 | ||||||
| with: | ||||||
|
|
@@ -22,10 +22,10 @@ jobs: | |||||
| test: | ||||||
| runs-on: ubuntu-latest | ||||||
| steps: | ||||||
| - uses: actions/checkout@v6 | ||||||
| - uses: actions/setup-go@v6 | ||||||
| with: | ||||||
| go-version: '1.26.x' | ||||||
|
There was a problem hiding this comment. The test job uses Go 1.26.x while go.mod declares Go 1.25.0. To ensure you keep compatibility with the declared minimum Go version, consider testing on 1.25.x (or a matrix that includes both 1.25.x and 1.26.x).
Suggested change
|
||||||
| - name: check-readme | ||||||
| run: | | ||||||
| go run ./scripts/update_readme.go | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -14,15 +14,15 @@ jobs: | |||||
| runs-on: ubuntu-latest | ||||||
| if: "startsWith(github.ref, 'refs/tags/v')" | ||||||
| steps: | ||||||
| - uses: actions/checkout@v6 | ||||||
| with: | ||||||
| fetch-depth: 0 | ||||||
| - run: git fetch --force --tags | ||||||
| - uses: actions/setup-go@v6 | ||||||
| with: | ||||||
| go-version: '1.26.x' | ||||||
|
There was a problem hiding this comment. Release builds use Go 1.26.x but go.mod declares Go 1.25.0. If Go 1.25 is intended to be the minimum supported version, consider aligning release builds to 1.25.x (or building in a matrix and publishing artifacts built with the minimum version) to avoid subtle differences introduced by a newer toolchain.
Suggested change
|
||||||
| cache: true | ||||||
| - uses: goreleaser/goreleaser-action@v7 | ||||||
| with: | ||||||
| distribution: goreleaser | ||||||
| version: latest | ||||||
|
|
@@ -38,8 +38,8 @@ jobs: | |||||
| runs-on: ubuntu-latest | ||||||
| if: "startsWith(github.ref, 'refs/tags/testutils/python/v')" | ||||||
| steps: | ||||||
| - uses: actions/checkout@v6 | ||||||
| - uses: actions/setup-python@v6 | ||||||
| with: | ||||||
| python-version: '3.13' | ||||||
| - name: Install deps | ||||||
|
|
@@ -57,7 +57,7 @@ jobs: | |||||
| runs-on: ubuntu-latest | ||||||
| if: "startsWith(github.ref, 'refs/tags/testutils/rust/v')" | ||||||
| steps: | ||||||
| - uses: actions/checkout@v6 | ||||||
| - run: cargo publish | ||||||
| working-directory: testutils/rust | ||||||
| env: | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is pinned to Go 1.26.x, but the module's go.mod declares Go 1.25.0. If 1.25 is the minimum supported version, consider running lint on 1.25.x (or using a version matrix for 1.25.x + 1.26.x) so CI doesn't accidentally rely on newer compiler/tooling behavior than consumers will have.