Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s Go dependencies and modernizes the GitHub Actions workflows to use newer action versions and Go toolchain versions.
Changes:
- Bumped multiple Go module dependencies (direct and indirect) in
go.mod/go.sum. - Updated the module Go version in
go.mod. - Updated CI/release workflows to newer
actions/*versions and a newer Go version.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
go.mod |
Updates the module Go version and bumps direct/indirect dependency versions. |
go.sum |
Refreshes module checksums to match updated dependencies. |
.github/workflows/ci.yaml |
Updates checkout/setup-go action versions and the Go version used for lint/test. |
.github/workflows/release.yaml |
Updates checkout/setup-go/setup-python + GoReleaser action versions and the Go version used for releases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - uses: actions/checkout@v6 | ||
| - uses: actions/setup-go@v6 | ||
| with: | ||
| go-version: '1.24.x' | ||
| go-version: '1.26.x' |
There was a problem hiding this comment.
CI is pinned to Go 1.26.x, but the module's go.mod declares Go 1.25.0. If 1.25 is the minimum supported version, consider running lint on 1.25.x (or using a version matrix for 1.25.x + 1.26.x) so CI doesn't accidentally rely on newer compiler/tooling behavior than consumers will have.
| - uses: actions/setup-go@v6 | ||
| with: | ||
| go-version: '1.24.x' | ||
| go-version: '1.26.x' |
There was a problem hiding this comment.
The test job uses Go 1.26.x while go.mod declares Go 1.25.0. To ensure you keep compatibility with the declared minimum Go version, consider testing on 1.25.x (or a matrix that includes both 1.25.x and 1.26.x).
| go-version: '1.26.x' | |
| go-version: '1.25.x' |
| - uses: actions/setup-go@v6 | ||
| with: | ||
| go-version: '1.24.x' | ||
| go-version: '1.26.x' |
There was a problem hiding this comment.
Release builds use Go 1.26.x but go.mod declares Go 1.25.0. If Go 1.25 is intended to be the minimum supported version, consider aligning release builds to 1.25.x (or building in a matrix and publishing artifacts built with the minimum version) to avoid subtle differences introduced by a newer toolchain.
| go-version: '1.26.x' | |
| go-version: '1.25.x' |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b78f8abf3d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - uses: actions/setup-go@v6 | ||
| with: | ||
| go-version: '1.24.x' | ||
| go-version: '1.26.x' |
There was a problem hiding this comment.
Keep CI on declared Go support floor
go.mod now declares go 1.25.0, but the CI test job runs only on 1.26.x; this drops coverage for the minimum supported toolchain and can let 1.26-only APIs or behavior slip in undetected until users build with 1.25. If 1.25 is still intended to be supported, pin CI to 1.25.x (or add a matrix including both 1.25.x and 1.26.x) so compatibility regressions are caught.
Useful? React with 👍 / 👎.
No description provided.