Removal of the layer count restriction by gchoqueux · Pull Request #2612 · iTowns/itowns

gchoqueux · 2025-10-09T16:36:05Z

See proposal ([proposal] Remove the restriction on the number of layers while simplifying the code. #2614 )

WARNING : There’s still unresolved bugs:

tiles disappear because of an improperly initialized bbox.
Opacity, vibility and effects haven’t been reconnected yet.

Description

Replace all textures array by just 2 textures, map and displacement map. All array textures are flatten in these maps.

Motivation and Context

removal of the layer count restriction
code simplification
first step :
- to replace LayeredMaterial with any Three.js materials
- to support any raster re-projection

Desplandis · 2025-10-10T07:21:23Z

Could you open a proposal for this PR? Describing what problem you want to resolve and explain your solution. =)

Neptilo · 2025-10-22T08:41:02Z

+
+        rtCache.set(textureSetId, renderTarget);
+    } else {
+        drawMap(renderTarget, tiles, renderer, extent);


If we're caching the render targets, what is the use of redrawing their textures every time we access them? Am I missing something?

Yes, it's temporary. I'll add a mechanism to update the texture and parent texture when the opacity changes.

Neptilo · 2025-10-22T08:52:02Z

+
+        drawMap(renderTarget, tiles, renderer, extent);
+
+        rtCache.set(textureSetId, renderTarget);


I was caching array render targets instead of array textures because it was impossible to extract the textures from the RTs and manage their memory separately, but maybe now that you're using simple render targets, this becomes possible and we can just maintain a cache of textures directly, and only use one RT for everything?

I'm not sure, There might be a problem with the framebuffer linked to the render target
To try

Neptilo · 2025-10-22T08:55:51Z

    renderer.setRenderTarget(previousRenderTarget);
+    renderer.setClearAlpha(a);

    return renderTarget;


The returned value is not used anymore and the documented type is now incorrect

it's draft PR, it's still evolving, no need for an in-depth review right now

Neptilo · 2025-10-22T09:26:26Z

 * @param tiles - An array of RasterTile objects, each containing textures.
 * @param max - The maximum number of layers for the DataArrayTexture.
 * @param type - Layer set identifier: 'c' for color, 'e' for elevation.
 * @param renderer - The renderer used to render textures.


To be updated

Neptilo · 2025-10-22T09:29:34Z

+        uniform vec4 offsetScale;
+        uniform float opacity;
+
+        const float CTOYL = 20037508.34 / 3.141592653589793 * 0.69314718;


Could you comment what these numbers represent?

i'll add some comment

20037508.34 : max projection in speudo mercator

0,69... : Ln(2)

What do you mean by "max projection"?

Neptilo · 2025-10-22T09:31:09Z

+    uniforms: {
+        // This uniform will be updated with each source 2D texture
+        map: { value: null },
+        texture_footprint: { value: new THREE.Vector2() },


Could you comment what these properties represent?

Footprint means the area/extent covered by something on the ground.

map: map to project on the ground

texture_footprint : texture coverage on ground

camera_footprint : camera coverage visible on ground

offsetScale: the map portion to be projected

Desplandis · 2026-04-07T07:48:32Z

@Neptilo @HoloTheDrunk Could you take a look to this PR this week?

Neptilo · 2026-04-08T12:53:50Z

                tile.material.setUniform('geoidHeight', geoidHeight);
+
+                const parent_uniforms = parent.material.uniforms;
+                const child_uniforms = tile.material.uniforms;


Use camel-case to keep coding style consistent.

Would you add camel-case in eslint rules ?

I think it would be good to do it eventually, but for now there would be too many variables to rename (111). In a separate PR, why not.

Neptilo · 2026-04-08T12:54:49Z

+                const parent_uniforms = parent.material.uniforms;
+                const child_uniforms = tile.material.uniforms;
+
+                if (parent.material.uniforms.map.value) {


You can use the previously defined parent_uniforms here.

Neptilo · 2026-04-08T13:03:00Z

+                    tile.setBBoxZ({ min: rasterElevationNode.min, max: rasterElevationNode.max, scale: rasterElevationNode.layer.scale, geoidHeight });
+                } else {
+                    tile.setBBoxZ({ min: parent.obb.z.min, max: parent.obb.z.max, geoidHeight });
+                }


An explanatory comment for all this added code would be nice.

Neptilo · 2026-04-08T14:01:16Z

+
+        float toY(float lat) {
+            float s = sin(lat);
+            return 0.5 * log2((1.0 + s) / (1.0 - s)) * CTOYL;


Where does this formula come from?

Neptilo · 2026-04-08T14:04:25Z

You could use this opportunity to already write this new file in TypeScript.

Neptilo · 2026-04-08T14:05:25Z

+
+const quad = new THREE.Mesh(geometry, materialUnit);

+export function drawMap(


Can you document the function?

Neptilo · 2026-04-08T14:17:03Z

-        depthBuffer: false, // No depth buffer needed for simple 2D texture copy
-    });
-    const arrayTexture = renderTarget.texture;
+const forwarding = (from, to) => ((from == to) ? 'transformUnit' : `${from} => ${to}`);


Can you document what materials contains and give forwarding a more explicit name? For example, "makeProjectionId" if you think that makes sense.

Neptilo · 2026-04-08T14:19:08Z

Could you document what the purpose of these materials is? As I understand it: running projection computations on the GPU?

BREACKING CHANGES: remove pdateLayeredMaterialNodeImagery, updateLayeredMaterialNodeElevation

… if raster tiles aren't loaded

gchoqueux added enhancement 🚀 refactor 🏭 labels Oct 9, 2025

gchoqueux force-pushed the refacto/oneMap branch from a424058 to e963972 Compare October 10, 2025 09:23

gchoqueux mentioned this pull request Oct 10, 2025

[proposal] Remove the restriction on the number of layers while simplifying the code. #2614

Open

gchoqueux force-pushed the refacto/oneMap branch from e963972 to c2a1517 Compare October 21, 2025 16:03

Neptilo reviewed Oct 22, 2025

View reviewed changes

gchoqueux force-pushed the refacto/oneMap branch from c2a1517 to 813670b Compare October 27, 2025 09:20

gchoqueux force-pushed the refacto/oneMap branch from 813670b to 92e746a Compare November 6, 2025 10:06

gchoqueux force-pushed the refacto/oneMap branch 2 times, most recently from 743300c to e40bdb5 Compare November 19, 2025 15:18

gchoqueux force-pushed the refacto/oneMap branch 3 times, most recently from 6b4f653 to b8f2e2e Compare December 15, 2025 14:04

gchoqueux force-pushed the refacto/oneMap branch from b8f2e2e to cfeace0 Compare January 6, 2026 13:42

gchoqueux force-pushed the refacto/oneMap branch from cfeace0 to 42f3068 Compare January 19, 2026 14:42

gchoqueux force-pushed the refacto/oneMap branch from 42f3068 to f81e8c3 Compare January 30, 2026 14:07

gchoqueux force-pushed the refacto/oneMap branch from f81e8c3 to 416a66e Compare March 4, 2026 13:23

gchoqueux force-pushed the refacto/oneMap branch from 416a66e to 3f507b4 Compare March 19, 2026 13:28

Desplandis requested a review from HoloTheDrunk April 7, 2026 07:48

Neptilo requested changes Apr 8, 2026

View reviewed changes

gchoqueux force-pushed the refacto/oneMap branch from 3f507b4 to 60ba0ac Compare April 23, 2026 12:36

gchoqueux mentioned this pull request Apr 30, 2026

Feat/tms and pbf #2756

Merged

gchoqueux force-pushed the refacto/oneMap branch 5 times, most recently from dfe65fd to 837c806 Compare May 4, 2026 15:39

gchoqueux mentioned this pull request May 6, 2026

feat: replace shaders with TSL equivalent #2764

Draft

gchoqueux force-pushed the refacto/oneMap branch 10 times, most recently from ea09d17 to 1033823 Compare May 13, 2026 14:44

gchoqueux force-pushed the refacto/oneMap branch 4 times, most recently from d552ff1 to 3f4a194 Compare May 20, 2026 09:08

gchoqueux force-pushed the refacto/oneMap branch 3 times, most recently from 2279834 to 0a88be2 Compare June 3, 2026 15:34

gchoqueux force-pushed the refacto/oneMap branch 2 times, most recently from a306bb9 to 6170906 Compare June 15, 2026 09:22

gchoqueux force-pushed the refacto/oneMap branch 2 times, most recently from 2fec763 to dd87cfe Compare June 16, 2026 15:09

gchoqueux added 7 commits July 1, 2026 14:58

refacto(RasterTile): simplify raster layer loading

c2514ea

BREACKING CHANGES: remove pdateLayeredMaterialNodeImagery, updateLayeredMaterialNodeElevation

fix(test): issues from refactoring and rebasing

78e9038

refacto(examples): use await top level to fetch

fd50220

fix(TiledGeometryLayer): [WIP][PROPOSAL] avoid to subdivide node mesh…

0f3cc5e

… if raster tiles aren't loaded

refacto(LayeredMaterial): one color map and one displacementMap.

6b1bc5b

refacto(composer): temp

086a5d8

refacto(composer): add pass

dd5453e

gchoqueux force-pushed the refacto/oneMap branch from dd87cfe to dd5453e Compare July 1, 2026 13:06


		drawMap(renderTarget, tiles, renderer, extent);

		rtCache.set(textureSetId, renderTarget);


		const quad = new THREE.Mesh(geometry, materialUnit);

		export function drawMap(

Uh oh!

Conversation

gchoqueux commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

Uh oh!

Desplandis commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gchoqueux Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gchoqueux Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gchoqueux Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Desplandis commented Apr 7, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gchoqueux commented Oct 9, 2025 •

edited

Loading

Desplandis commented Oct 10, 2025 •

edited

Loading

gchoqueux Oct 22, 2025 •

edited

Loading

gchoqueux Oct 22, 2025 •

edited

Loading

gchoqueux Oct 22, 2025 •

edited

Loading