Skip to content

Feat/tms and pbf#2756

Merged
ftoromanoff merged 3 commits into
iTowns:masterfrom
ftoromanoff:feat/tmsAndPbf
Jun 5, 2026
Merged

Feat/tms and pbf#2756
ftoromanoff merged 3 commits into
iTowns:masterfrom
ftoromanoff:feat/tmsAndPbf

Conversation

@ftoromanoff

@ftoromanoff ftoromanoff commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Linked with issue #2738 .

Currently, pbf format is only use in VectorTileSource and thus need a MapBoxStyle file. But there are cases where we have vector tile data in pbf that are not linked to a MapBoxVector tile as in the issue #2738.

This PR allows the use of pbf without a defined MapBoxStyle.
and fix a bug with partial Texture that was rendering some tile in black

@ftoromanoff ftoromanoff force-pushed the feat/tmsAndPbf branch 3 times, most recently from d62002b to 9ed12e7 Compare April 30, 2026 09:21
@ftoromanoff ftoromanoff marked this pull request as ready for review April 30, 2026 12:04
@gchoqueux

gchoqueux commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

#2612 simplify the texture rendering. All textures are rendering in on texture instead of 3D texture. It removes the exceptions and specificities in makeDataArrayRenderTarget see drawMap. Do you think I need to make changes?

@Desplandis Desplandis requested review from Neptilo and jailln April 30, 2026 13:32
@jailln jailln requested review from airnez and removed request for Neptilo and jailln April 30, 2026 14:12

@airnez airnez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except my few remarks on examples, the code looks good to me 👍
Also remember to put preview images for the new examples in examples/images/thumbnails (Required since #2754 )

Comment thread examples/tms_pbf_3d_BF.html Outdated
Comment thread examples/tms_pbf_3d_BF.html Outdated
Comment thread examples/tms_pbf_3d_BF.html Outdated
Comment thread examples/vector_tile_raster_2d_BF.html Outdated
Comment thread examples/vector_tile_raster_2d_BF.html Outdated
Comment thread examples/vector_tile_raster_2d_BF.html Outdated
@ftoromanoff

ftoromanoff commented May 11, 2026

Copy link
Copy Markdown
Contributor Author

Except my few remarks on examples, the code looks good to me 👍 Also remember to put preview images for the new examples in examples/images/thumbnails (Required since #2754 )

Hello,
This example was aimed to be put on master. It's an example that illustrated the issue referenced in #2738 and to check that's it's indeed fixed.
IF this PR is approved I will remove the example before merging.

But it's good to pointed that out, as I might have forgotten ^^

@ftoromanoff ftoromanoff requested a review from airnez May 11, 2026 12:18

@airnez airnez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@ftoromanoff ftoromanoff merged commit 4fa9b47 into iTowns:master Jun 5, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants