Skip to content

fix(redis): migrate to read_routing_strategy API #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AndreyErmilov wants to merge 1 commit into
base: next
Choose a base branch
from
Open

fix(redis): migrate to read_routing_strategy API #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions hitbox-redis/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Changed
- Bump minimum `redis` dependency to 1.2 and migrate from deprecated `ClusterClientBuilder::read_from_replicas()` to `read_routing_strategy(RandomReplicaStrategy)`.

## [0.2.1] - 2026-02-09

Expand Down
2 changes: 1 addition & 1 deletion hitbox-redis/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ keywords = ["cache", "async", "cache-backend", "hitbox", "redis"]
hitbox-backend = { path = "../hitbox-backend", version = "0.2" }
hitbox = { path = "../hitbox", version = "0.2" }
log = "0.4"
redis = { version = "1.0", features = ["tokio-comp", "connection-manager"] }
redis = { version = "1.2", features = ["tokio-comp", "connection-manager"] }
thiserror = { workspace = true }
async-trait = { workspace = true }
serde = { workspace = true }
Expand Down
4 changes: 3 additions & 1 deletion hitbox-redis/src/backend.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,9 @@ where
config.nodes.iter().map(|s| s.as_str()),
);
if config.read_from_replicas {
builder = builder.read_from_replicas();
builder = builder.read_routing_strategy(
redis::cluster_read_routing::RandomReplicaStrategy,
);
}
if let Some(ref username) = self.username {
builder = builder.username(username.clone());
Expand Down
4 changes: 2 additions & 2 deletions hitbox-test/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ jaq-std = "2.1.0"
jaq-json = { version = "1.1.0", features = ["serde_json"] }
serial_test = "3.2"
tempfile = "3"
testcontainers = { version = "0.26", default-features = false }
testcontainers-modules = { version = "0.14", default-features = false, features = ["redis"] }
testcontainers = { version = "0.27", default-features = false }
testcontainers-modules = { version = "0.15", default-features = false, features = ["redis"] }

[dependencies.rkyv]
workspace = true
Expand Down
Loading