fix(redis): migrate to read_routing_strategy API#277
Open
AndreyErmilov wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #277 +/- ##
==========================================
- Coverage 84.20% 84.16% -0.05%
==========================================
Files 136 136
Lines 9435 9440 +5
==========================================
Hits 7945 7945
- Misses 1490 1495 +5 ☔ View full report in Codecov by Sentry. |
Replace the deprecated `ClusterClientBuilder::read_from_replicas()` call with `read_routing_strategy(RandomReplicaStrategy)`, introduced in redis 1.2.0. Bump the minimum `redis` dependency to 1.2 so downstream users resolve a version that ships the new API. Fixes `-D warnings` clippy failures on every open PR once cargo resolves redis 1.2.0 or newer.
AndreyErmilov
force-pushed
the
fix/redis-deprecation
branch
from
27c8e7c to
7670423
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the deprecated
ClusterClientBuilder::read_from_replicas()call withread_routing_strategy(RandomReplicaStrategy), introduced in redis 1.2.0. Bump the minimumredisdependency to 1.2 so downstream users resolve a version that ships the new API.Fixes
-D warningsclippy failures on every open PR once cargo resolves redis 1.2.0 or newer.