Add support for directives on directive definitions#1206
Open
BoD wants to merge 7 commits into
Open
Conversation
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This was referenced Dec 18, 2025
Contributor
Author
|
Related graphql-js PR: graphql/graphql-js#4521 |
Contributor
|
Another use case: |
leebyron
added
📄 Draft (RFC 2)
yaacovCR
added a commit
to graphql/graphql-js
that referenced
this pull request
Apr 24, 2026
Allow directives on directive definitions, based on [this spec PR](graphql/graphql-spec#1206) which introduces this syntax: ```graphql directive @onDirective on DIRECTIVE_DEFINITION directive @foo @onDirective on OBJECT directive @baz @deprecated(reason: "...") on OBJECT extend directive @quux @deprecated(reason: "...") ``` Co-authored-by: Martin Bonnin <martin@mbonnin.net> Co-authored-by: Jerel Miller <jerelmiller@gmail.com> Co-authored-by: Yaacov Rydzinski <yaacovCR@gmail.com>
yaacovCR
reviewed
May 7, 2026
mjmahone
reviewed
May 15, 2026
|
|
||
| ### Directive Extensions | ||
|
|
||
| DirectiveExtension : extend directive @ Name Directives[Const] |
Contributor
There was a problem hiding this comment.
This is interesting: should we be able to extend a directive with new arguments? We can extend a type with new fields that themselves have new arguments.
There is even a special Schema Coordinate for directive arguments.
Contributor
Author
There was a problem hiding this comment.
Good question!
In my opinion, I think yes it would probably make sense in principle to have that ability, even if for consistency alone.
That being said, I would rather tackle this in a separate change later, and based on demand for it.
Curious to know what others think!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to apply directives to directive definitions and to deprecate directives, with this syntax:
With @IvanGoncharov's blessing, this PR is a continuation and updated version of #907 which I think can be closed. (There's also prior art in #567).
Motivation
Allow applying directive-exclusive features (e.g.
@specifyBy,@deprecated) on directives.For instance, on Apollo Kotlin we'd like to deprecate some client side directives.