Add experimental support for directives on directive definitions#4521
Merged
yaacovCR merged 26 commits intoApr 24, 2026
Conversation
|
@BoD is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Jan 6, 2026
This was referenced Mar 17, 2026
leebyron
approved these changes
Apr 2, 2026
Contributor
|
Update includeDeprecated arg per @benjie 's comments, then we'll merge |
Contributor
Author
|
Just made the change for |
jerelmiller
reviewed
Apr 3, 2026
Contributor
jerelmiller
left a comment
jerelmiller
left a comment
There was a problem hiding this comment.
Had a few suggestions, mostly around types, but otherwise looks good from my end!
You probably want to get a proper review from someone who knows the conventions in this codebase better than I do, but wanted to try and help move this along in some way!
Member
|
I've not fully reviewed this PR, but the changes since Lee's review all look fine to me - thanks @BoD! 👍 |
…ied to a directive
Co-authored-by: Jerel Miller <jerelmiller@gmail.com>
Co-authored-by: Jerel Miller <jerelmiller@gmail.com>
Co-authored-by: Jerel Miller <jerelmiller@gmail.com>
Co-authored-by: Jerel Miller <jerelmiller@gmail.com>
Co-authored-by: Jerel Miller <jerelmiller@gmail.com>
yaacovCR
force-pushed
the
directive-on-directive-definitions
branch
2 times, most recently
from
cd3b99e to
06a336c
Compare
yaacovCR
added
spec RFC
yaacovCR
force-pushed
the
directive-on-directive-definitions
branch
from
06a336c to
a9e07a6
Compare
Contributor
|
@BoD dropped in a few commits with fixes, possibly spec for some of them has to be correlated => have to check out ci failures a bit later…. |
yaacovCR
force-pushed
the
directive-on-directive-definitions
branch
from
a9e07a6 to
e287ba1
Compare
yaacovCR
approved these changes
Apr 24, 2026
yaacovCR
changed the title
yaacovCR
added a commit
that referenced
this pull request
May 6, 2026
## v16.14.0 (2026-05-03) #### New Feature 🚀 * [#4317](#4317) Allow configuration of the `ofType` introspection depth ([@Nols1000](https://github.com/Nols1000)) * [#4521](#4521) Add experimental support for directives on directive definitions ([@BoD](https://github.com/BoD)) #### Bug Fix 🐞 * [#4652](#4652) Fix valueFromAST variable own-property checks ([@abishekgiri](https://github.com/abishekgiri)) #### Docs 📝 * [#4706](#4706) Fix mistake in GraphQLError guidance ([@benjie](https://github.com/benjie)) #### Committers: 4 * Abishek Kumar Giri([@abishekgiri](https://github.com/abishekgiri)) * Benjie([@benjie](https://github.com/benjie)) * Benoit 'BoD' Lubek([@BoD](https://github.com/BoD)) * Nils-Börge Margotti([@Nols1000](https://github.com/Nols1000))
1 task
yaacovCR
added a commit
that referenced
this pull request
May 8, 2026
yaacovCR
added a commit
that referenced
this pull request
May 10, 2026
## v17.0.0-beta.1 (2026-05-10) #### Breaking Change 💥 * [#4729](#4729) subscribe: replace perEventExecutor with mapSourceToResponseEvent ([@yaacovCR](https://github.com/yaacovCR)) * [#4730](#4730) chore(engines): drop Node 20 support ([@yaacovCR](https://github.com/yaacovCR)) * [#4731](#4731) refactor(execution): extract buildResolveInfo helper ([@yaacovCR](https://github.com/yaacovCR)) #### New Feature 🚀 * [#4733](#4733) feat: support node v26 ([@yaacovCR](https://github.com/yaacovCR)) #### Bug Fix 🐞 * [#4725](#4725) chore: forward-port directives on directive definitions (#4521) ([@yaacovCR](https://github.com/yaacovCR)) * [#4727](#4727) chore: forward-port configuration of the `ofType` introspection depth (#4317) ([@yaacovCR](https://github.com/yaacovCR)) #### Polish 💅 * [#4728](#4728) polish: group FRAGMENT_VARIABLE_DEFINITION with executable defs ([@yaacovCR](https://github.com/yaacovCR)) #### Internal 🏠 <details> <summary> 3 PRs were merged </summary> * [#4460](#4460) internal: use node experimental-strip-types instead of ts-node ([@yaacovCR](https://github.com/yaacovCR)) * [#4732](#4732) internal: use node test instead of mocha + c8 ([@yaacovCR](https://github.com/yaacovCR)) * [#4734](#4734) internal: add comment re: rewriteRelativeImportExtensions ([@yaacovCR](https://github.com/yaacovCR)) </details> #### Committers: 1 * Yaacov Rydzinski ([@yaacovCR](https://github.com/yaacovCR))
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow directives on directive definitions, based on this spec PR which introduces this syntax:
Disclaimer
First time on this codebase and am also not a JS/TS person, so obvious mistakes and/or missing pieces are very likely 😅 Any help and feedback to improve this PR are very welcome 🙏. The tests seem to pass but additional tests may be needed.