Skip to content

feat: Add AddToTransactions to SentryAttachment #5182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamescrosswell wants to merge 5 commits into
base: main
Choose a base branch
from

Windows verify tests

39fe419
Select commit
Loading
Failed to load commit list.
Open

feat: Add AddToTransactions to SentryAttachment #5182

Windows verify tests
39fe419
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden: code-review completed May 5, 2026 in 38s

1 issue

code-review: Found 1 issue (1 medium)

Medium

Adding parameters to public FromTransaction is a binary-breaking change - `src/Sentry/Protocol/Envelopes/Envelope.cs:340-343`

Envelope.FromTransaction is a public method whose signature changes from FromTransaction(SentryTransaction) to FromTransaction(SentryTransaction, IDiagnosticLogger?, IReadOnlyCollection<SentryAttachment>?). While source-compatible (the new parameters are optional), this is binary-breaking: assemblies compiled against the prior version will throw MissingMethodException at runtime when calling the original single-argument overload. Consumers that reference Sentry as a precompiled dependency would need to recompile. Consider preserving the original single-arg overload that delegates to the new method to maintain binary compatibility.

Duration: 36.7s · Tokens: 326.6k in / 4.1k out · Cost: $2.45

Annotations

Check warning on line 343 in src/Sentry/Protocol/Envelopes/Envelope.cs

See this annotation in the file changed.

@sentry-warden sentry-warden / warden: code-review

Adding parameters to public FromTransaction is a binary-breaking change 

`Envelope.FromTransaction` is a public method whose signature changes from `FromTransaction(SentryTransaction)` to `FromTransaction(SentryTransaction, IDiagnosticLogger?, IReadOnlyCollection<SentryAttachment>?)`. While source-compatible (the new parameters are optional), this is binary-breaking: assemblies compiled against the prior version will throw `MissingMethodException` at runtime when calling the original single-argument overload. Consumers that reference Sentry as a precompiled dependency would need to recompile. Consider preserving the original single-arg overload that delegates to the new method to maintain binary compatibility.
View more details on @sentry/warden