Skip to content

Windows verify tests

39fe419
Select commit
Loading
Failed to load commit list.
Open

feat: Add AddToTransactions to SentryAttachment #5182

Windows verify tests
39fe419
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden completed May 5, 2026 in 1m 6s

1 issue

Medium

Adding parameters to public FromTransaction is a binary-breaking change - `src/Sentry/Protocol/Envelopes/Envelope.cs:340-343`

Envelope.FromTransaction is a public method whose signature changes from FromTransaction(SentryTransaction) to FromTransaction(SentryTransaction, IDiagnosticLogger?, IReadOnlyCollection<SentryAttachment>?). While source-compatible (the new parameters are optional), this is binary-breaking: assemblies compiled against the prior version will throw MissingMethodException at runtime when calling the original single-argument overload. Consumers that reference Sentry as a precompiled dependency would need to recompile. Consider preserving the original single-arg overload that delegates to the new method to maintain binary compatibility.

4 skills analyzed
Skill Findings Duration Cost
code-review 1 36.7s $2.45
find-bugs 0 1m 4s $1.40
gha-security-review 0 35.6s $0.98
security-review 0 1m 2s $1.04

Duration: 3m 18s · Tokens: 964.1k in / 6.0k out · Cost: $5.87