Migrate DatasetIndex from BTable to GTable and Add Local Sorting to GTable#21728
Merged
davelopez merged 12 commits intogalaxyproject:devfrom Feb 5, 2026
Merged
Conversation
itisAliRH
changed the title
This was referenced Feb 3, 2026
itisAliRH
added
the
kind/refactoring
davelopez
reviewed
Feb 4, 2026
itisAliRH
force-pushed
the
btable-to-gtable-dataset-index
branch
from
2a9f986 to
e4bf353
Compare
- Add noLocalSorting prop (default: false) to enable/disable local sorting - Implement local sorting logic that sorts items by the selected column - Support string, number, and mixed type comparisons with localeCompare - Handle null/undefined values properly in sorting - Apply field formatters before comparison if available - When noLocalSorting=true, emit sort-changed event only (current behavior) - When noLocalSorting=false, sort items locally and emit event
- Replace b-table with GTable component - Add TableField type import for proper typing - Add CSS to hide table header using scoped styles and :deep() - Update fields definition with proper type annotation - Maintain backward compatibility with directory listing display ref galaxyproject#21703
- Add tests for table rendering with valid dataset content - Add tests for error states (not composite, not directory, not found) - Add test for fields configuration - Add test for subdirectory filtering - Ensure error messages display without table rendering - Mock datasetPathDestination composable and computedAsync
Co-authored-by: David López <46503462+davelopez@users.noreply.github.com>
Co-authored-by: David López <46503462+davelopez@users.noreply.github.com>
Co-authored-by: David López <46503462+davelopez@users.noreply.github.com>
Co-authored-by: David López <46503462+davelopez@users.noreply.github.com>
Co-authored-by: David López <46503462+davelopez@users.noreply.github.com>
Co-authored-by: David López <46503462+davelopez@users.noreply.github.com>
Co-authored-by: David López <46503462+davelopez@users.noreply.github.com>
itisAliRH
force-pushed
the
btable-to-gtable-dataset-index
branch
from
e4bf353 to
9cc2a21
Compare
Change prop from negative to positive naming convention for better readability. The prop now defaults to true (local sorting enabled) and uses positive boolean logic instead of double negatives.
itisAliRH
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates
DatasetIndex.vuefrom Bootstrap-Vue'sBTableto our customGTablecomponent, as part of the ongoing effort tracked in #21703.required #21727
Summary
DatasetIndexto useGTable.GTablewith newnoLocalSortingprop (default false) so sortable columns work out of the box.DatasetIndex.How to test the changes?
(Select all options that apply)
Insert Markdown Objects->History->Dataset Indexand select the composite datasetLicense