Skip to content

Migrate CleanupResultDialog from BTable to GTable#21729

Merged
davelopez merged 2 commits intogalaxyproject:devfrom
itisAliRH:btable-to-gtable-cleanup-result-dialog
Feb 5, 2026
Merged

Migrate CleanupResultDialog from BTable to GTable#21729
davelopez merged 2 commits intogalaxyproject:devfrom
itisAliRH:btable-to-gtable-cleanup-result-dialog

Conversation

@itisAliRH
Copy link
Copy Markdown
Member

@itisAliRH itisAliRH commented Feb 3, 2026

This PR migrates CleanupResultDialog.vue from Bootstrap-Vue's BTable to our custom GTable component, as part of the ongoing effort tracked in #21703.

required #21728

Before After
image image

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions Bot added this to the 26.1 milestone Feb 3, 2026
@itisAliRH itisAliRH added the kind/refactoring cleanup or refactoring of existing code, no functional changes label Feb 3, 2026
@davelopez
Copy link
Copy Markdown
Contributor

Can you rebase this one? Otherwise, it is ready to go.

- Replace b-table-lite with GTable component
- Add TableField type import for proper typing
- Update errorFields definition with TableField[] type
- Improve conditional rendering with v-else-if="result"

ref galaxyproject#21703 (14/48 components)
@itisAliRH itisAliRH force-pushed the btable-to-gtable-cleanup-result-dialog branch from b5727d4 to ebeda43 Compare February 5, 2026 13:24
@itisAliRH
Copy link
Copy Markdown
Member Author

Failed tests are irrelevant.

Copy link
Copy Markdown
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@davelopez davelopez merged commit 4df97cd into galaxyproject:dev Feb 5, 2026
34 of 36 checks passed
@itisAliRH itisAliRH deleted the btable-to-gtable-cleanup-result-dialog branch February 5, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants