Show persistent best practice results in workflow editor#19546
Merged
mvdbeek merged 49 commits intogalaxyproject:devfrom Feb 17, 2026
Merged
Show persistent best practice results in workflow editor#19546mvdbeek merged 49 commits intogalaxyproject:devfrom
mvdbeek merged 49 commits intogalaxyproject:devfrom
Conversation
davelopez
reviewed
Feb 6, 2025
Member
Author
|
Just noticed that disconnected when inputs don't appear ... they definitely should though. |
707c516 to
57b4595
Compare
57b4595 to
bbeb38e
Compare
Member
|
I've made minor additions here, and provided a screencast at the top. Will provide a detailed description once all is complete. For now, there are a few remaining items/bugs I am working on:
|
11c763f to
b00e8ee
Compare
7c1b2af to
d4ae0cd
Compare
c2266b1 to
016162e
Compare
Member
|
Failing tests should be unrelated |
…t at all Used `v-show` for that purpose.
Co-authored-by: Claude <noreply@anthropic.com>
Implemented a logic which - if no position argument is provided in a refactor action that involves adding/extracting an input for a workflow - makes sure the input position does not overlap any existing workflow step (including multiple inputs potentially added in a singular refactor action).
Co-authored-by: Claude <noreply@anthropic.com>
The transform/viewport was not being reset to what it was before we would do a refactor action that would add new steps. This also adds those transform retention methods from the Index.vue component to the existing `workflowBoundingBox` composable.
Co-authored-by: Claude <noreply@anthropic.com>
Adds an entire `lintingTypes.d.ts` file to store not just the schema defined refactor request types for each action, but also all types of "lint state" objects generated on the client for those requests.
This now allows users to refactor a workflow for a prior version as well, instead of just being able to refactor just the `StoredWorkflow.latest_workflow`.
TODO: This will all be typed once we migrate this component and its parent (Index.vue) to composition API and TS.
016162e to
004bb7a
Compare
davelopez
approved these changes
Feb 17, 2026
Contributor
davelopez
left a comment
There was a problem hiding this comment.
Super cool! Thank you all!
Member
Author
|
Thank you @ahmedhamidawan! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Persistent and Reactive Best Practices in Workflow Editor
This PR significantly improves the Best Practices activity in the workflow editor, making it persistent, reactive, and
more user-friendly. It also adds the ability to refactor specific workflow versions and updates the workflow object on every save (updating step indices to prevent having inconsistent indices).
persistent_best_practice_results_FINAL.mp4
Best Practices Activity Improvements
Progress Tracking & Visual Feedback
Loading overlay during workflow save operations
Interactive Highlighting
Workflow Version Selector Improvements
Refactoring Specific Workflow Versions
A new feature allowing users to refactor a specific workflow version (not just the latest):
versionparameter to the refactor workflow API endpointpersistent_best_practice_results_Refactor_old_v.mp4
Viewport Transform Retention
Fixes the issue where the viewport would jump after saving or refactoring:
useWorkflowBoundingBoxcomposable with comprehensive testsBug Fixes & Polish
completes (since now we
_loadCurrenton every save)Lint.vue,LintSection.vue, andRefactorConfirmationModal.vueto Composition API + TypeScriptInitial description by Marius
People just keep on creating workflows with disconnected inputs, I really want this to be front and center.
How to test the changes?
(Select all options that apply)
License