Hack Best Practices into special workflow thing

Author: mvdbeek

client/src/components/ActivityBar/ActivityBar.vue

@@ -258,6 +258,7 @@ defineExpose({
                                 v-else
                                 :id="`${activity.id}`"
                                 :key="activity.id"
+                                :indicator="activity.indicator"
                                 :activity-bar-id="props.activityBarId"
                                 :icon="activity.icon"
                                 :is-active="isActiveRoute(activity.to)"
@@ -304,6 +305,7 @@ defineExpose({
                         :key="activity.id"
                         :activity-bar-id="props.activityBarId"
                         :icon="activity.icon"
+                        :indicator="activity.indicator"
                         :is-active="panelActivityIsActive(activity)"
                         :title="activity.title"
                         :tooltip="activity.tooltip"
@@ -316,6 +318,7 @@ defineExpose({
                         :key="activity.id"
                         :activity-bar-id="props.activityBarId"
                         :icon="activity.icon"
+                        :indicator="activity.indicator"
                         :is-active="isActiveRoute(activity.to)"
                         :title="activity.title"
                         :tooltip="activity.tooltip"

client/src/components/Workflow/Editor/Index.vue

@@ -1,6 +1,5 @@
 <template>
     <div id="columns" class="d-flex">
-        <div>{{ lintData.disconnectedInputs }}</div>
         <StateUpgradeModal :state-messages="stateMessages" />
         <StateUpgradeModal
             :state-messages="insertedStateMessages"
@@ -460,10 +459,12 @@ export default {
         }
 
         const isNewTempWorkflow = computed(() => !props.workflowId);
+        const lintData = useLintData(id, steps, datatypesMapper);
 
         const { specialWorkflowActivities } = useSpecialWorkflowActivities(
             computed(() => ({
                 hasInvalidConnections: hasInvalidConnections.value,
+                lintData: lintData,
             }))
         );
 
@@ -483,8 +484,6 @@ export default {
         const { confirm } = useConfirmDialog();
         const inputs = getWorkflowInputs();
 
-        const lintData = useLintData(id, steps, datatypesMapper);
-
         return {
             id,
             name,

client/src/components/Workflow/Editor/Lint.test.js

@@ -2,11 +2,12 @@ import { createTestingPinia } from "@pinia/testing";
 import { mount } from "@vue/test-utils";
 import { PiniaVuePlugin, setActivePinia } from "pinia";
 import { getLocalVue } from "tests/jest/helpers";
+import { ref } from "vue";
 
 import { testDatatypesMapper } from "@/components/Datatypes/test_fixtures";
 import { useWorkflowStepStore } from "@/stores/workflowStepStore";
 
-import { getUntypedWorkflowParameters } from "./modules/parameters";
+import { useLintData } from "./modules/useLinting";
 
 import Lint from "./Lint.vue";
 
@@ -30,6 +31,8 @@ const steps = {
             },
         ],
         annotation: "",
+        input_connections: null,
+        tool_state: null,
     },
     1: {
         id: 1,
@@ -72,6 +75,7 @@ const steps = {
                 output_name: "output",
             },
         ],
+        tool_state: null,
     },
     2: {
         id: 2,
@@ -80,8 +84,11 @@ const steps = {
         annotation: "",
         outpus: {},
         inputs: [],
+        input_connections: null,
+        tool_state: null,
     },
 };
+const stepsRef = ref(steps);
 
 describe("Lint", () => {
     let wrapper;
@@ -93,7 +100,7 @@ describe("Lint", () => {
 
         wrapper = mount(Lint, {
             propsData: {
-                untypedParameters: getUntypedWorkflowParameters(steps),
+                lintData: useLintData(ref("1"), stepsRef, ref(testDatatypesMapper)),
                 steps: steps,
                 annotation: "annotation",
                 license: null,