Skip to content

Move the 'search in' selection to a menu#1741

Open
gzsombor wants to merge 1 commit into
eclipse-jdt:masterfrom
gzsombor:search-in-menu
Open

Move the 'search in' selection to a menu#1741
gzsombor wants to merge 1 commit into
eclipse-jdt:masterfrom
gzsombor:search-in-menu

Conversation

@gzsombor
Copy link
Copy Markdown
Contributor

What it does

Currently one must open a modal dialog to limit what kind of sources should the call-hierarchy view show, but using modal dialogs are not great user experience, using easily accessible checkboxes and instant response makes the experience faster.

How to test

Old dialog:
old
New menu:
new

Author checklist

@eclipse-jdt-bot
Copy link
Copy Markdown
Contributor

eclipse-jdt-bot commented Nov 26, 2024

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

org.eclipse.jdt.ui/META-INF/MANIFEST.MF
org.eclipse.jdt.ui/pom.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 0d91390358975d79ad62757b8139f89f76658d21 Mon Sep 17 00:00:00 2001
From: Eclipse JDT Bot <jdt-bot@eclipse.org>
Date: Tue, 4 Mar 2025 22:29:41 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/org.eclipse.jdt.ui/META-INF/MANIFEST.MF b/org.eclipse.jdt.ui/META-INF/MANIFEST.MF
index 4b40cbd0de..2fdd246b79 100644
--- a/org.eclipse.jdt.ui/META-INF/MANIFEST.MF
+++ b/org.eclipse.jdt.ui/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Automatic-Module-Name: org.eclipse.jdt.ui
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.jdt.ui; singleton:=true
-Bundle-Version: 3.34.0.qualifier
+Bundle-Version: 3.34.100.qualifier
 Bundle-Activator: org.eclipse.jdt.internal.ui.JavaPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %providerName
diff --git a/org.eclipse.jdt.ui/pom.xml b/org.eclipse.jdt.ui/pom.xml
index 18c081b362..40e55928a7 100644
--- a/org.eclipse.jdt.ui/pom.xml
+++ b/org.eclipse.jdt.ui/pom.xml
@@ -18,7 +18,7 @@
   </parent>
   <groupId>org.eclipse.jdt</groupId>
   <artifactId>org.eclipse.jdt.ui</artifactId>
-  <version>3.34.0-SNAPSHOT</version>
+  <version>3.34.100-SNAPSHOT</version>
   <packaging>eclipse-plugin</packaging>
 
 	<build>
-- 
2.48.1

Further information are available in Common Build Issues - Missing version increments.

@gzsombor
Copy link
Copy Markdown
Contributor Author

I don't think the reported warning : "The API problem filter for: 'The field org.eclipse.jdt.ui.text.IJavaPartitions.JAVA_MARKDOWN_COMMENT in an interface that is intended to be implemented or extended has been added' is no longer used" is related to anything that this patch is changing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants