Semantic Tokens ext point by BoykoAlex · Pull Request #1683 · eclipse-jdt/eclipse.jdt.ui

BoykoAlex · 2024-09-28T00:10:16Z

Extension point to contribute semantic tokens into the JDT Java editor.

martinlippert · 2024-10-14T11:04:18Z

After the initial discussion in #1594, this is the corresponding PR with the implementation. Would be extremely awesome if someone could have a look and provide feedback, so that we can get this merged whenever it makes sense.

Interested @noopur2507, @iloveeclipse, @HannesWell ?

HannesWell · 2024-10-14T20:36:46Z

After the initial discussion in #1594, this is the corresponding PR with the implementation. Would be extremely awesome if someone could have a look and provide feedback, so that we can get this merged whenever it makes sense.

Interested @noopur2507, @iloveeclipse, @HannesWell ?

Unfortunately I'm not a JDT committer and cannot say with certainty who would be the best person to review this.
Besides the other one you mentioned, maybe @mickaelistria can have a look since he also works on LS integration?

mickaelistria · 2024-10-14T20:46:22Z

I'm not a committer on JDT either ( https://projects.eclipse.org/projects/eclipse.jdt/elections/election-mickael-istria-committer-eclipse-jdt-java-development-tools ). I've put some generic comments about documentation and API that needs to be polished.

BoykoAlex · 2024-10-18T15:35:30Z

@mickaelistria @martinlippert updated the PR for Mickael's comments

martinlippert · 2024-10-18T19:27:26Z

@BoykoAlex Thanks for incorporating the comments from @mickaelistria (and thanks a lot @mickaelistria for taking a look, much appreciated).

Now looking for a JDT UI committer to pick this up and provide feedback, merge, or whatever makes sense to move this forward.

jukzi · 2024-10-28T08:33:25Z

 	 */
 	private Highlighting fJobDeprecatedMemberHighlighting;

+	private Highlighting[] fEditorHighlightings;


does this duplicate a hack? better find a solution?

No, I think this code needs to move up and be collocated with with the similar definition for semantic highlightings. There is one field for whatever came in from the viewer definition and one for whatever the current reconciling job can use. To be honest this comment relates more to fJobSemanticHighlightings rather than fJobDeprecatedMemberHighlighting... Reconciling job may have highlightings different from the reconciler if colour settings have changed while reconciling text chunk in the editor, hence I think this is okay.

jukzi · 2024-10-28T08:44:13Z

This change is rather complex to review, fails the automated tests and does not come with junit testcases.
At best the added API is tested with junit and used within jdt.ui itself or comes with a examples, so it will be actually tested by users. Please also add description how to systematically test including screenshots what to expect. If you have fixed all issues you may ping me for review. The merge may have to wait until an M1.

BoykoAlex · 2024-10-29T23:36:38Z

@jukzi thank you for the feedback. I have added an example extnesion point in the .text.tests plugin and a simple unit test. The build fails on "plugins not loaded" test sometimes... I don't understand why it fails sometimes... I don't see what I could hav e broken there yet...

jukzi · 2024-10-30T07:32:27Z

If you are are sure PluginsNotLoadedTest is unrelated (likely) then please create an issue for it and link it. i have not found an existing issue for it.

iloveeclipse · 2024-10-30T09:08:49Z

If you are are sure PluginsNotLoadedTest is unrelated

I believe it is related, the test is not known as unstable.

BoykoAlex · 2024-10-30T16:55:36Z

@iloveeclipse I don't think the test failure is related as other PRs such as:

Add new quick fix for unused pattern variable / unused lambda variable #1747
Move the 'search in' selection to a menu #1741
Update jdt.ui's main README #1707 (looks like MD file change)

All have the same test failure. Likely something has changed in the platform upstream.
I'll open a new issue for the test failure.

BoykoAlex · 2024-10-30T17:06:29Z

If you are are sure PluginsNotLoadedTest is unrelated (likely) then please create an issue for it and link it. i have not found an existing issue for it.

@jukzi I have created #1754 for the failed test

BoykoAlex · 2024-11-06T04:10:14Z

@jukzi the PR should be okay to review now. Could you please have another look at it when you get a chance? :-)

BoykoAlex · 2024-12-05T15:54:54Z

The test failures seem unrelated. I noticed the same number of failed tests in the recently created PRs...

jukzi · 2024-12-06T07:10:26Z

rebased to get rid of build errors

review applied

jukzi · 2024-12-09T15:30:23Z

unrelated SmokeViewsTest.testOpenSourceView can be ignored #1843

jukzi · 2024-12-09T15:31:14Z

let's give it a try

martinlippert · 2024-12-09T15:49:48Z

So many thanks to @jukzi for reviewing and guiding us through this PR, so much appreciated. 1000 Thanks!!!

BoykoAlex mentioned this pull request Sep 28, 2024

Java editor syntax highlighting via extension point #1594

Closed

BoykoAlex changed the title ~~Sync jdt syntax highlighting~~ Semantic Tokens ext point Sep 28, 2024

BoykoAlex force-pushed the sync-jdt-syntax-highlighting branch from 3e87ca0 to 9332408 Compare October 1, 2024 15:23

mickaelistria suggested changes Oct 15, 2024

View reviewed changes

Comment thread org.eclipse.jdt.ui/schema/semanticTokens.exsd Outdated

Comment thread org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/text/java/SemanticTokensProvider.java Outdated

jukzi reviewed Oct 28, 2024

View reviewed changes

Comment thread org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/text/java/ISemanticTokensProvider.java

jukzi reviewed Oct 28, 2024

View reviewed changes

Comment thread ...eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/SemanticHighlightingReconciler.java Outdated

jukzi reviewed Oct 28, 2024

View reviewed changes

BoykoAlex force-pushed the sync-jdt-syntax-highlighting branch from 43ebedf to 336cf12 Compare October 28, 2024 20:44