Several bug fixes for Seed reTerminal - #80
Merged
Merged
Conversation
The number of shading levels affects widget rendering (stroke widths, icon styles, grid visibility) regardless of whether e-ink optimization is enabled, so the field name should not imply it's tied to grayscale-only or optimization-only behavior. Renaming it now, ahead of moving it out of the Advanced section, also makes room for a future color-display equivalent. Adds a 1.2 -> 1.3 config entry migration to rename the stored option key on existing installations. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
display_levels affects widget rendering (stroke widths, icon styles, grid visibility) regardless of e-ink optimization, so it no longer belongs inside the Advanced section. It's now a top-level field on the Display Settings form. The remaining Advanced fields (dither algorithm, measured palette, exposure, saturation) only affect optimize_for_eink(), which early-returns when optimize is off, so that section is now hidden until "E-ink optimization" is checked. Toggling optimize on requires saving once and reopening Display Settings for the section to appear, since HA config flow schemas are static per form render. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…tant The display_settings options step fell back to the global DEFAULT_DISPLAY_LEVELS (16) when no value was stored yet, ignoring the device's own preset (e.g. reterminal_e1002 supports 256 levels, trmnl_og only 2). Resolve the preset first and use its display_levels as the fallback default so a fresh entry pre-selects a value the device can actually reproduce.
OpenDisplay firmware reports the panel's native buffer as landscape (1872x1404), not portrait. The old preset caused a spurious 90° rotation on the default landscape orientation, producing a portrait PNG that OpenDisplay's own fit logic then mangled trying to place back into its actual landscape buffer. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Python Test Results1 051 tests +11 1 051 ✅ +11 24s ⏱️ ±0s Results for commit 863577a. ± Comparison against base commit 581a040. This pull request removes 4 and adds 15 tests. Note that renamed tests count towards both. |
|
Hi, I have a question. It is possible to test it? I don’t know how to handle it. Can you give a how to use it? |
Owner
Author
|
Somewhere on your HA box you have a custom_components directory and there is an eink_dashboard directory. If you clone this repo and run |
|
Thanks a lot. I am afraid to crash my actually configuration. I think it is better for me to wait for update maybe a pre release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.