fix(config): correct reTerminal E1003 native orientation to landscape

OpenDisplay firmware reports the panel's native buffer as landscape
(1872x1404), not portrait. The old preset caused a spurious 90°
rotation on the default landscape orientation, producing a portrait
PNG that OpenDisplay's own fit logic then mangled trying to place
back into its actual landscape buffer.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Author: cryptomilk

CHANGELOG.md

@@ -14,6 +14,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   conditions are met the tile renders inverted (solid black card,
   white text/icon) as an e-ink "needs attention" signal.
 
+### Fixed
+
+- **Seeed reTerminal E1003** device preset now declares its correct
+  native landscape orientation, fixing a spurious 90° rotation that
+  produced a portrait PNG for the default landscape setup. Existing
+  dashboards are fixed automatically on upgrade via a config entry
+  migration; no manual reconfiguration is needed.
+
 ## [0.6.0] - 2026-07-07
 
 ### Added

README.md

@@ -81,7 +81,7 @@ Supported device presets:
 | TRMNL X | 1872 × 1404 | 16 |
 | TRMNL RGB | 2560 × 1440 | 2 (black & white) |
 | Seeed reTerminal E1001 | 800 × 480 | 4 |
-| Seeed reTerminal E1003 | 1404 × 1872 | 16 |
+| Seeed reTerminal E1003 | 1872 × 1404 | 16 |
 | Custom | user-defined | 16 |
 
 ### Step 2 -- Image delivery

custom_components/eink_dashboard/__init__.py

@@ -51,6 +51,7 @@
     NumberFormat,
     TimeFormat,
     WidgetType,
+    resolve_display,
 )
 from .http import EinkLayoutView, EinkPublicImageView
 from .store import EinkDashboardStore
@@ -735,6 +736,12 @@ async def async_migrate_entry(
     ``display_levels`` so the option name also fits future color
     e-ink displays.
 
+    Version 1.3 → 1.4: recompute ``width``, ``height``, and
+    ``rotation`` for ``reterminal_e1003`` entries.  The device's
+    native orientation preset was previously wrong, so entries
+    created before the fix have a stale ``rotation`` baked in that
+    produces a 90°-rotated image.
+
     Args:
         hass: Home Assistant instance.
         config_entry: The config entry to migrate.
@@ -774,6 +781,27 @@ async def async_migrate_entry(
             minor_version=3,
         )
 
+    if config_entry.minor_version == 3:
+        _LOGGER.debug(
+            "Migrating %s from minor version %d to 4",
+            config_entry.entry_id,
+            config_entry.minor_version,
+        )
+        new_options = dict(config_entry.options)
+        if new_options.get("device_model") == "reterminal_e1003":
+            orientation = new_options.get("orientation", "landscape")
+            width, height, rotation, _preset = resolve_display(
+                "reterminal_e1003", orientation
+            )
+            new_options["width"] = width
+            new_options["height"] = height
+            new_options["rotation"] = rotation
+        hass.config_entries.async_update_entry(
+            config_entry,
+            options=new_options,
+            minor_version=4,
+        )
+
     return True
 
 

custom_components/eink_dashboard/config_flow.py

@@ -303,7 +303,7 @@ class EinkDashboardConfigFlow(ConfigFlow, domain=DOMAIN):
     """Multi-step config flow for creating a new dashboard entry."""
 
     VERSION = 1
-    MINOR_VERSION = 3
+    MINOR_VERSION = 4
 
     def __init__(self) -> None:
         """Initialise flow state."""

custom_components/eink_dashboard/const.py

@@ -183,11 +183,12 @@ class DevicePreset:
     ),
     "reterminal_e1003": DevicePreset(
         "reTerminal E1003",
-        1404,
         1872,
+        1404,
         16,
         False,
         "Seeed",
+        native_landscape=True,
         integration_dithers=True,
     ),
     "custom": DevicePreset(

tests/test_config_flow.py

@@ -202,8 +202,32 @@ async def test_reterminal_e1003_creates_entry(
         opts = result["options"]
         assert opts["optimize"] is False
         assert opts["display_levels"] == 16
+        # Panel is native landscape (OpenDisplay firmware), so portrait
+        # orientation is achieved by rotating the rendered canvas.
         assert opts["width"] == 1404
         assert opts["height"] == 1872
+        assert opts["rotation"] == 90
+
+    async def test_reterminal_e1003_landscape_creates_entry(
+        self, hass: HomeAssistant
+    ) -> None:
+        # Native landscape device in landscape orientation (the
+        # default): no rotation, and dimensions match the panel's
+        # native landscape buffer.
+        flow = await _make_config_flow(hass)
+        result = await flow.async_step_user(
+            {
+                "name": "Office",
+                "device_model": "reterminal_e1003",
+                "orientation": "landscape",
+                "update_interval": 60,
+            }
+        )
+
+        assert result["type"] is FlowResultType.CREATE_ENTRY
+        opts = result["options"]
+        assert opts["width"] == 1872
+        assert opts["height"] == 1404
         assert opts["rotation"] == 0
 
     async def test_screen_portion_shows_form_for_trmnl(
@@ -1808,7 +1832,7 @@ async def test_migration_removes_sharpness_contrast(
     ) -> None:
         # Migration from minor_version<2 removes sharpness/contrast and
         # adds exposure/saturation with their defaults. The entry then
-        # cascades through the 2->3 migration too, ending at 3.
+        # cascades through the 2->3 and 3->4 migrations too, ending at 4.
         from custom_components.eink_dashboard import async_migrate_entry
 
         entry = MockConfigEntry(
@@ -1827,7 +1851,7 @@ async def test_migration_removes_sharpness_contrast(
         result = await async_migrate_entry(hass, entry)
 
         assert result is True
-        assert entry.minor_version == 3
+        assert entry.minor_version == 4
         assert "sharpness" not in entry.options
         assert "contrast" not in entry.options
         assert entry.options["exposure"] == 1.0
@@ -1863,7 +1887,8 @@ async def test_migration_renames_grayscale_levels(
         self, hass: HomeAssistant
     ) -> None:
         # Migration from minor_version<3 renames the stored
-        # grayscale_levels option key to display_levels.
+        # grayscale_levels option key to display_levels. The entry
+        # then cascades through the 3->4 migration too, ending at 4.
         from custom_components.eink_dashboard import async_migrate_entry
 
         entry = MockConfigEntry(
@@ -1882,21 +1907,113 @@ async def test_migration_renames_grayscale_levels(
         result = await async_migrate_entry(hass, entry)
 
         assert result is True
-        assert entry.minor_version == 3
+        assert entry.minor_version == 4
         assert "grayscale_levels" not in entry.options
         assert entry.options["display_levels"] == 4
 
-    async def test_migration_skipped_when_already_at_minor_version_3(
+    async def test_migration_fixes_reterminal_e1003_landscape_rotation(
         self,
         hass: HomeAssistant,
     ) -> None:
-        # Entries already at minor_version=3 are not migrated again.
+        # Migration from minor_version<4 recomputes width/height/
+        # rotation for reterminal_e1003 entries created under the old,
+        # buggy preset. A landscape entry had a stale rotation=90
+        # baked in; the fix clears it to 0.
         from custom_components.eink_dashboard import async_migrate_entry
 
         entry = MockConfigEntry(
             domain=DOMAIN,
             minor_version=3,
             entry_id="test-entry",
+            options={
+                "device_model": "reterminal_e1003",
+                "orientation": "landscape",
+                "width": 1872,
+                "height": 1404,
+                "rotation": 90,
+            },
+        )
+        entry.add_to_hass(hass)
+
+        result = await async_migrate_entry(hass, entry)
+
+        assert result is True
+        assert entry.minor_version == 4
+        assert entry.options["width"] == 1872
+        assert entry.options["height"] == 1404
+        assert entry.options["rotation"] == 0
+
+    async def test_migration_fixes_reterminal_e1003_portrait_rotation(
+        self,
+        hass: HomeAssistant,
+    ) -> None:
+        # A portrait reterminal_e1003 entry had a stale rotation=0
+        # baked in under the old preset; the fix sets it to 90.
+        from custom_components.eink_dashboard import async_migrate_entry
+
+        entry = MockConfigEntry(
+            domain=DOMAIN,
+            minor_version=3,
+            entry_id="test-entry",
+            options={
+                "device_model": "reterminal_e1003",
+                "orientation": "portrait",
+                "width": 1404,
+                "height": 1872,
+                "rotation": 0,
+            },
+        )
+        entry.add_to_hass(hass)
+
+        result = await async_migrate_entry(hass, entry)
+
+        assert result is True
+        assert entry.minor_version == 4
+        assert entry.options["width"] == 1404
+        assert entry.options["height"] == 1872
+        assert entry.options["rotation"] == 90
+
+    async def test_migration_skips_non_e1003_devices(
+        self,
+        hass: HomeAssistant,
+    ) -> None:
+        # Entries for other device models must not have their
+        # width/height/rotation touched by the 3->4 migration.
+        from custom_components.eink_dashboard import async_migrate_entry
+
+        entry = MockConfigEntry(
+            domain=DOMAIN,
+            minor_version=3,
+            entry_id="test-entry",
+            options={
+                "device_model": "kindle_pw",
+                "orientation": "portrait",
+                "width": 758,
+                "height": 1024,
+                "rotation": 0,
+            },
+        )
+        entry.add_to_hass(hass)
+
+        result = await async_migrate_entry(hass, entry)
+
+        assert result is True
+        assert entry.minor_version == 4
+        assert entry.options["width"] == 758
+        assert entry.options["height"] == 1024
+        assert entry.options["rotation"] == 0
+
+    async def test_migration_skipped_when_already_at_minor_version_4(
+        self,
+        hass: HomeAssistant,
+    ) -> None:
+        # Entries already at minor_version=4 are not migrated again.
+        from custom_components.eink_dashboard import async_migrate_entry
+
+        entry = MockConfigEntry(
+            domain=DOMAIN,
+            minor_version=4,
+            entry_id="test-entry",
             options={
                 "update_interval": 60,
                 "exposure": 1.0,