Skip to content

ci: harden elements GPG key import in install_noded.sh#2621

Merged
k9ert merged 1 commit into
cryptoadvance:masterfrom
al-munazzim:fix/ci-elements-gpg-subkey-import
May 11, 2026
Merged

ci: harden elements GPG key import in install_noded.sh#2621
k9ert merged 1 commit into
cryptoadvance:masterfrom
al-munazzim:fix/ci-elements-gpg-subkey-import

Conversation

@al-munazzim
Copy link
Copy Markdown
Contributor

@al-munazzim al-munazzim commented May 11, 2026

Summary

This PR fixes a deterministic CI bootstrap failure in the shared Install elementsd step (tests/install_noded.sh --elements binary).

In failing runs, GPG verification of elements/SHA256SUMS.asc failed with NO_PUBKEY 2F2A88D7F8D68E87, which caused all three test jobs (test, extension-smoketest, cypress) to fail before executing project tests.

Root cause

gpg_verify_sums() imported from keys.openpgp.org first and continued on success, skipping ubuntu keyserver fallback. In some runs this led to incomplete key material for older signatures/subkeys, so no trusted VALIDSIG was found.

Change

  • Import release keys from both sources (keys.openpgp.org and keyserver.ubuntu.com) instead of short-circuiting after the first import.
  • Count a key as imported only if the key exists in the local keyring after attempts.

Security posture is unchanged: verification still requires VALIDSIG for the pinned trusted primary fingerprint and still enforces committed SHA256 trust anchors.

Validation

  • bash -n tests/install_noded.sh
  • Local run: ./tests/install_noded.sh --debug --elements binary
    • confirms GOODSIG 2F2A88... + VALIDSIG ... 8CC974...
    • completes elementsd install successfully

Expected impact

Once merged, rerunning PR #2620 should no longer fail in Install elementsd due to this key-import path.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 11, 2026

Deploy Preview for specter-desktop-docs canceled.

Name Link
🔨 Latest commit 6c46ad5
🔍 Latest deploy log https://app.netlify.com/projects/specter-desktop-docs/deploys/6a01a17eba840800084ca3cc

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@k9ert k9ert merged commit 64139eb into cryptoadvance:master May 11, 2026
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants