ci: harden elements GPG key import in install_noded.sh#2621
Merged
k9ert merged 1 commit intoMay 11, 2026
Conversation
✅ Deploy Preview for specter-desktop-docs canceled.
|
k9ert
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a deterministic CI bootstrap failure in the shared
Install elementsdstep (tests/install_noded.sh --elements binary).In failing runs, GPG verification of
elements/SHA256SUMS.ascfailed withNO_PUBKEY 2F2A88D7F8D68E87, which caused all three test jobs (test,extension-smoketest,cypress) to fail before executing project tests.Root cause
gpg_verify_sums()imported fromkeys.openpgp.orgfirst andcontinued on success, skipping ubuntu keyserver fallback. In some runs this led to incomplete key material for older signatures/subkeys, so no trustedVALIDSIGwas found.Change
keys.openpgp.organdkeyserver.ubuntu.com) instead of short-circuiting after the first import.Security posture is unchanged: verification still requires
VALIDSIGfor the pinned trusted primary fingerprint and still enforces committed SHA256 trust anchors.Validation
bash -n tests/install_noded.sh./tests/install_noded.sh --debug --elements binaryGOODSIG 2F2A88...+VALIDSIG ... 8CC974...Expected impact
Once merged, rerunning PR #2620 should no longer fail in
Install elementsddue to this key-import path.