Update specterext-timelockrecovery to v0.2.3#2620
Conversation
✅ Deploy Preview for specter-desktop-docs canceled.
|
|
Review (security + bug-risk): I checked this bump from specterext-timelockrecovery 0.2.1 -> 0.2.3 and the upstream delta (v0.2.1...v0.2.3). What changed upstream:
Security assessment:
Potential bug/regression risks to watch:
Suggested checks before merge:
Verdict: looks directionally good and addresses a real correctness bug; I’d merge after the above regression checks are green. |
|
Thanks for the CI signal — I dug into the failing runs in detail.\n\nThe 3 red checks (, , ) are not caused by the extension version bump itself. All three fail early in the shared bootstrap step () with:\n\n- \n- \n\nSo the jobs fail before Python deps/tests for this PR’s code changes are exercised.\n\nI’ll prepare a separate PR to harden/fix this CI verification path. Once that is merged, we should be able to rerun this PR and get the checks green here as well. |
|
Correction (my previous comment had formatting issues): Thanks for the CI signal — I dug into the failing runs in detail. The 3 red checks (
So the jobs fail before Python deps/tests for this PR’s code changes are exercised. I’ll prepare a separate PR to harden/fix this CI verification path. Once that is merged, we should be able to rerun this PR and get the checks green here as well. |
|
Follow-up is up: #2621\n\nIt hardens This script will result in having bitcoind or elementsd binaries, either by binary download or via compilation |
|
Correction (previous comment had shell-formatting issues): Follow-up is up: #2621 It hardens After #2621 merges, we can rerun this PR and checks should be able to go green. |
09e9846 to
84265fb
Compare
|
Rebased over @al-munazzim last commit |
Fixed floating point errors when converting BTC amount from BTC to sats (multiplying by 1e8).
Added descriptors to input of the recovery-transaction and the cancellation-transaction - necessary for some hardware wallets (i.e. Specter DIY) to identify the inputs.
Added descriptors to the self-sending outputs of the recovery-transaction and cancellation-transaction - will be displayed better on some hardware wallets (i.e. don't deduct from total-amount, show address-index and don't make it look like an external destination).